-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-1822: Update NRS fixed slit association rules for background eligibility #5994
JP-1822: Update NRS fixed slit association rules for background eligibility #5994
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Obligatory "don't forget the changelog"
I modified the jw00626 pool file to contain SPAT_NUM, and it runs successfully. However, the two unit tests with coverage of this edit are failing, so I think I may have a bit of maintenance to take care of first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates to the actual ASN code look good. Of course unit tests need fixing now.
…gd-asn-rules merge with master for up-to-date regtest results
Codecov Report
@@ Coverage Diff @@
## master #5994 +/- ##
==========================================
- Coverage 77.81% 77.65% -0.17%
==========================================
Files 399 405 +6
Lines 35354 36726 +1372
==========================================
+ Hits 27512 28519 +1007
- Misses 7842 8207 +365
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
obligatory "update changelog" but LGTM.
Closes #5547
Resolves JP-1822
Description
This PR addresses the usage of science exposures as backgrounds for other science exposures in an observation with fixed slit nods; this is accomplished by using the SPAT_NUM keyword to match exposures with different spatial nod positions for use as backgrounds in each other's associations.
NOTE: Waiting for an up-to-date pool file for testing before merge.
Checklist