Speed up NRS IFU footprint computation #5969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbushouse
reviewed
Apr 19, 2021
jwst/assign_wcs/nirspec.py
Outdated
| slit_name : int or str | ||
| Slit.name of an open slit. | ||
| wavelength_range: list | ||
| Wavelength range for the combination of fliter and grating. |
| (1874.8184744639657, 1929.9072657798927))} | ||
|
|
||
| hdul = create_nirspec_ifu_file("F290LP", "G140M") | ||
| im = datamodels.ImageModel(hdul) |
There was a problem hiding this comment.
Should this be an IFUImageModel or does it not matter to the usage here?
Codecov Report
@@ Coverage Diff @@
## master #5969 +/- ##
==========================================
- Coverage 77.81% 77.78% -0.04%
==========================================
Files 404 404
Lines 35352 35464 +112
==========================================
+ Hits 27509 27584 +75
- Misses 7843 7880 +37
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
jemorrison
reviewed
Apr 19, 2021
jwst/assign_wcs/util.py
Outdated
| ------- | ||
| footprint : ndarray | ||
| The spatial footprint | ||
| spctral_region : tuple |
There was a problem hiding this comment.
should be spectral_region (not spectral_region)
jemorrison
reviewed
Apr 19, 2021
jwst/assign_wcs/util.py
Outdated
| footprint : ndarray | ||
| The spatial footprint | ||
| spctral_region : tuple | ||
| The wavwlength range for the observation. |
There was a problem hiding this comment.
typo - should be wavelength
jemorrison
approved these changes
Apr 19, 2021
|
Can we merge this so I can use it in cube_build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR speeds up the computation of NIRSpec IFU footprints by using the WCS transforms directly,
instead of through the WCS object. Most of the transforms are reused and only slice specific differences are
computed.
The computed spectral range is saved in
meta.wcsinfo.spectral_range. It's not saved in the FITS file.This is necessary for improving cube_build performance.
The "true" bounding box in the test was computed using the previous implementation with evaluating the WCS object.
Checklist