Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate variance arrays into SlitModel used as input for ResampleSpecStep #5941

Conversation

jdavies-st
Copy link
Collaborator

@jdavies-st jdavies-st commented Apr 7, 2021

Addresses #5798
Addresses JP-1944

Description

This PR allows propagation of the variance arrays of the inputs to ResampleSpecStep. Previously these were being dropped on the floor when converting an ImageModel into a SlitModel, which happens in the case of MIRI LRS.

Regression tests pass on this branch.

This is of course needed if we are to use the variance arrays for weighting and to compute uncertainties in the resampled products.

  • Tests
  • Documentation
  • Change log
  • Milestone
  • Label(s)

@jdavies-st jdavies-st added this to the Build 7.8 milestone Apr 7, 2021
@jdavies-st jdavies-st requested a review from hbushouse April 7, 2021 23:34
@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #5941 (72eab2e) into master (c5cfcd5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5941   +/-   ##
=======================================
  Coverage   77.91%   77.91%           
=======================================
  Files         403      403           
  Lines       35359    35392   +33     
=======================================
+ Hits        27549    27575   +26     
- Misses       7810     7817    +7     
Flag Coverage Δ *Carryforward flag
nightly 77.91% <ø> (ø) Carriedforward from c5cfcd5
unit 56.03% <100.00%> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/resample/resample_spec_step.py 90.51% <100.00%> (-4.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5cfcd5...72eab2e. Read the comment docs.

@jdavies-st jdavies-st force-pushed the JP-1944-propogate-var-into-resample branch from 4708d22 to 72eab2e Compare April 8, 2021 13:24
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdavies-st jdavies-st merged commit cd5fcd4 into spacetelescope:master Apr 8, 2021
@jdavies-st jdavies-st deleted the JP-1944-propogate-var-into-resample branch April 8, 2021 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants