JP-2032: Fix bug introduced when adding 4-amp subarray processing in refpix step #5937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5937 +/- ##
==========================================
+ Coverage 77.79% 77.89% +0.09%
==========================================
Files 403 403
Lines 35358 35549 +191
==========================================
+ Hits 27507 27690 +183
- Misses 7851 7859 +8
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
hbushouse
approved these changes
Apr 7, 2021
hbushouse
reviewed
Apr 7, 2021
|
So once the CI tests finish (successfully) I think this will be ready to merge, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5936
Resolves JP-2032
Description
This PR addresses JP-2032. JP-1929 introduced a bug into the refpix step for 1-amp readout NIR subarrays. This PR fixes it. Unit tests and regression test now run.
Checklist