Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused SubtractImagesStep #5919

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

jdavies-st
Copy link
Collaborator

@jdavies-st jdavies-st commented Mar 29, 2021

Description

This PR removes the unused SubtractImagesStep which is old code that was completely replaced by BackgroundStep. This code is untested. And I believe unneeded?

Checklist

  • Tests
  • Documentation
  • Change log
  • Milestone
  • Label(s)

@jdavies-st jdavies-st added this to the Build 7.8 milestone Mar 29, 2021
@jdavies-st jdavies-st requested a review from hbushouse March 29, 2021 15:53
@jdavies-st jdavies-st force-pushed the remove-subtract-images branch 2 times, most recently from 56dbcca to 0c01141 Compare March 29, 2021 16:31
@jdavies-st jdavies-st force-pushed the remove-subtract-images branch from 0c01141 to e356aab Compare March 29, 2021 16:59
@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #5919 (e356aab) into master (06e021f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5919      +/-   ##
==========================================
+ Coverage   77.86%   77.88%   +0.01%     
==========================================
  Files         400      400              
  Lines       35273    35295      +22     
==========================================
+ Hits        27465    27489      +24     
+ Misses       7808     7806       -2     
Flag Coverage Δ *Carryforward flag
nightly 77.86% <100.00%> (ø) Carriedforward from 06e021f
unit 56.05% <100.00%> (+0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/lib/suffix.py 100.00% <ø> (+4.00%) ⬆️
jwst/step.py 100.00% <ø> (ø)
jwst/stpipe/integration.py 100.00% <ø> (ø)
jwst/background/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06e021f...e356aab. Read the comment docs.

@jdavies-st jdavies-st merged commit 3b8a77f into spacetelescope:master Mar 30, 2021
@jdavies-st jdavies-st deleted the remove-subtract-images branch March 30, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants