Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-1963: Add rshift fitgeom option to tweakreg docs #5899

Merged
merged 2 commits into from
Mar 19, 2021

Conversation

hbushouse
Copy link
Collaborator

@hbushouse hbushouse commented Mar 19, 2021

Closes #5841
Resolves JP-1963

Description

This PR updates the "tweakreg" step docs to add the "rshift" option to the list of allowed values for the "fitgeometry" param. It also expands the list of allowed values to add a brief description of the meaning of each value.

Checklist

  • Tests
  • Documentation
  • Change log
  • Milestone
  • Label(s)

@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #5899 (70fe0cf) into master (a46bea8) will not change coverage.
The diff coverage is n/a.

❗ Current head 70fe0cf differs from pull request most recent head 9c016e2. Consider uploading reports for the commit 9c016e2 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5899   +/-   ##
=======================================
  Coverage   78.00%   78.00%           
=======================================
  Files         401      401           
  Lines       35285    35285           
=======================================
  Hits        27524    27524           
  Misses       7761     7761           
Flag Coverage Δ *Carryforward flag
nightly 78.00% <ø> (ø) Carriedforward from a46bea8
unit 56.04% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a46bea8...9c016e2. Read the comment docs.

@hbushouse
Copy link
Collaborator Author

@cracraft
Copy link
Collaborator

The updates look good to me. Thanks.

@hbushouse hbushouse merged commit 6b4eda0 into spacetelescope:master Mar 19, 2021
@hbushouse hbushouse deleted the jp1963_tweakreg_docs branch March 19, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update tweakreg documentation for rshift parameter
3 participants