JP-2005: Update NIS WFSS ASN rules for matching filter #5896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5896 +/- ##
==========================================
+ Coverage 77.83% 77.86% +0.02%
==========================================
Files 401 401
Lines 35285 35339 +54
==========================================
+ Hits 27465 27516 +51
- Misses 7820 7823 +3
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
hbushouse
requested review from
stscieisenhamer,
tapastro and
jdavies-st
and removed request for
tapastro
stscieisenhamer
approved these changes
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5893
Resolves JP-2005
Description
This PR fixes the problem of having NIRISS WFSS grism exposure spec2 ASN's associate a direct image that uses a different filter than the grism image. The level-2b WFSS ASN rule has been updated to make sure the associated direct image has the same PUPIL value as the grism image, in the same way the NIRCam WFSS images must have the same channel value.
Finally managed (with much effort) to get new truth files for association regtests loaded into place properly in artifactory. When looking for WFSS-related parts of association docs to update I noticed the use of the DMS-specific "level" terminology, which I changed to the public-facing "stage" terminology. So this is all ready to go now.
Checklist