Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-1863: Correct offset in cross-dispersion axis for NIRISS WFSS extraction boxes #5809

Merged

Conversation

tapastro
Copy link
Contributor

@tapastro tapastro commented Mar 5, 2021

Resolves JP-1863
Resolves #5640

This changes the center of the extraction bounding box from:
- an average in grism pixel space
to:
- the sky position, transformed to the grism pixel space.

This has not fixed all offset issues, but my best guess in location of the remaining error would be in some combination of source astrometry and transform polynomials. Would like feedback from INS team.

@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #5809 (dd7d324) into master (f8d9122) will decrease coverage by 0.04%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5809      +/-   ##
==========================================
- Coverage   76.49%   76.45%   -0.05%     
==========================================
  Files         406      406              
  Lines       36248    37445    +1197     
==========================================
+ Hits        27728    28628     +900     
- Misses       8520     8817     +297     
Flag Coverage Δ *Carryforward flag
nightly 76.49% <50.00%> (ø) Carriedforward from f8d9122
unit 54.50% <50.00%> (-0.13%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/assign_wcs/util.py 80.00% <50.00%> (+1.11%) ⬆️
jwst/cube_build/cube_overlap.py 83.21% <0.00%> (-10.96%) ⬇️
jwst/skymatch/region.py 74.42% <0.00%> (-6.15%) ⬇️
jwst/ami/utils.py 73.48% <0.00%> (-4.78%) ⬇️
jwst/resample/resample.py 92.30% <0.00%> (-3.89%) ⬇️
jwst/rscd/rscd_sub.py 41.54% <0.00%> (-3.58%) ⬇️
jwst/ami/analyticnrm2.py 82.83% <0.00%> (-2.62%) ⬇️
jwst/associations/lib/rules_level2b.py 94.59% <0.00%> (-1.92%) ⬇️
jwst/ramp_fitting/create_cube.py 6.48% <0.00%> (-1.85%) ⬇️
jwst/associations/lib/rules_level3.py 97.53% <0.00%> (-1.71%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8d9122...dd7d324. Read the comment docs.

@tapastro tapastro merged commit cfcd455 into spacetelescope:master Mar 8, 2021
tapastro added a commit that referenced this pull request Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WFSS traces not centered in the extraction boxes
2 participants