Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-1887: ramp_fit PEP8 cleanup #5803

Merged
merged 5 commits into from
Mar 3, 2021

Conversation

kmacdonald-stsci
Copy link
Contributor

@kmacdonald-stsci kmacdonald-stsci commented Mar 2, 2021

Made style changes to ramp_fit.py based on adding E2 to the flake8 configuration, as well as using autopep8 and pylint.

Addresses #5701 / JP-1887

Copy link
Collaborator

@jdavies-st jdavies-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jdavies-st jdavies-st changed the title Jp 1887 Making Style Changes JP-1887: Making Style Changes Mar 3, 2021
@jdavies-st jdavies-st changed the title JP-1887: Making Style Changes JP-1887: ramp_fit PEP8 cleanup Mar 3, 2021
@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #5803 (801a0aa) into master (8dd1f43) will increase coverage by 0.14%.
The diff coverage is 83.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5803      +/-   ##
==========================================
+ Coverage   76.63%   76.77%   +0.14%     
==========================================
  Files         406      406              
  Lines       36243    36688     +445     
==========================================
+ Hits        27774    28169     +395     
- Misses       8469     8519      +50     
Flag Coverage Δ *Carryforward flag
nightly 76.63% <80.23%> (ø) Carriedforward from 8dd1f43
unit 54.61% <85.83%> (?)

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/ramp_fitting/ramp_fit.py 82.23% <83.57%> (+2.71%) ⬆️
jwst/associations/asn_edit.py 66.66% <0.00%> (-0.75%) ⬇️
jwst/associations/lib/process_list.py 73.49% <0.00%> (-0.59%) ⬇️
jwst/fits_generator/template.py 16.98% <0.00%> (-0.27%) ⬇️
jwst/timeconversion/time_conversion.py 10.96% <0.00%> (-0.08%) ⬇️
jwst/datamodels/make_header.py 91.38% <0.00%> (+0.02%) ⬆️
jwst/associations/lib/product_utils.py 94.82% <0.00%> (+0.09%) ⬆️
jwst/regtest/conftest.py 90.96% <0.00%> (+1.20%) ⬆️
jwst/tso_photometry/tso_photometry_step.py 77.41% <0.00%> (+1.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dd1f43...801a0aa. Read the comment docs.

@jdavies-st jdavies-st merged commit afd8f5a into spacetelescope:master Mar 3, 2021
@kmacdonald-stsci kmacdonald-stsci deleted the jp_1887_style branch March 5, 2021 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants