-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-1931: Add/Rename V2-V3 frame axes names #5765
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5765 +/- ##
==========================================
+ Coverage 75.93% 75.98% +0.04%
==========================================
Files 406 406
Lines 36135 36391 +256
==========================================
+ Hits 27439 27650 +211
- Misses 8696 8741 +45
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just add an entry to CHANGES.rst
2f53f7c
to
53c4e70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I do not understand how can code coverage change after this PR. It is just renaming things. |
Codecov seems to be having some technical difficulties right now. |
This PR changes the case of V2-V3 axes for NIRSPEC from
V2
->v2
and adds axes names forv2v3
frames for other instruments. This takes care of #5602 (comment) and item#4
in #5746 (comment)This PR also fixes units for the
v2v3
frame for NIRCAM (u.deg
->u.arcsec
) as described in item#2
in #5746 (comment).However, I have noticed many other (than
v2v3
) frames also do not have axes names.Resolves #5770 / JP-1931