Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-1931: Add/Rename V2-V3 frame axes names #5765

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

mcara
Copy link
Member

@mcara mcara commented Feb 18, 2021

This PR changes the case of V2-V3 axes for NIRSPEC from V2->v2 and adds axes names for v2v3 frames for other instruments. This takes care of #5602 (comment) and item #4 in #5746 (comment)

This PR also fixes units for the v2v3 frame for NIRCAM (u.deg->u.arcsec) as described in item #2 in #5746 (comment).

However, I have noticed many other (than v2v3) frames also do not have axes names.

Resolves #5770 / JP-1931

@mcara mcara requested a review from nden February 18, 2021 23:55
@mcara mcara self-assigned this Feb 18, 2021
@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #5765 (53c4e70) into master (1133e42) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5765      +/-   ##
==========================================
+ Coverage   75.93%   75.98%   +0.04%     
==========================================
  Files         406      406              
  Lines       36135    36391     +256     
==========================================
+ Hits        27439    27650     +211     
- Misses       8696     8741      +45     
Flag Coverage Δ *Carryforward flag
nightly 75.93% <100.00%> (ø) Carriedforward from 1133e42
unit 54.61% <87.50%> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/assign_wcs/fgs.py 72.22% <100.00%> (-22.65%) ⬇️
jwst/assign_wcs/miri.py 87.08% <100.00%> (-2.88%) ⬇️
jwst/assign_wcs/nircam.py 88.67% <100.00%> (+0.32%) ⬆️
jwst/assign_wcs/niriss.py 80.10% <100.00%> (+2.98%) ⬆️
jwst/assign_wcs/nirspec.py 93.91% <100.00%> (ø)
jwst/group_scale/group_scale.py 100.00% <100.00%> (ø)
jwst/group_scale/group_scale_step.py 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba2e741...53c4e70. Read the comment docs.

@mcara mcara changed the title Add/Rename V2-V3 frame axes names JP-1931: Add/Rename V2-V3 frame axes names Feb 19, 2021
@mcara mcara requested a review from jdavies-st February 19, 2021 16:49
Copy link
Collaborator

@jdavies-st jdavies-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just add an entry to CHANGES.rst

@jdavies-st jdavies-st added this to the Build 7.7.x milestone Feb 19, 2021
@mcara mcara force-pushed the fix-axes-names-case branch from 2f53f7c to 53c4e70 Compare February 19, 2021 17:27
Copy link
Collaborator

@nden nden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcara
Copy link
Member Author

mcara commented Feb 19, 2021

I do not understand how can code coverage change after this PR. It is just renaming things.

@jdavies-st
Copy link
Collaborator

Codecov seems to be having some technical difficulties right now.

@mcara mcara merged commit b79ecfa into spacetelescope:master Feb 19, 2021
@mcara mcara deleted the fix-axes-names-case branch May 13, 2021 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some V2V3 frames are missing axes names and have wrong units
3 participants