Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-1876: Add new Lvl2 association rule for NRSLAMPImage #5740

Merged

Conversation

tapastro
Copy link
Contributor

@tapastro tapastro commented Feb 11, 2021

Resolves JP-1876
Resolves #5664

Added new association rule, modified regression test results for two association pools.

NOTE: This PR requires edits to the regtest truth files.

@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #5740 (9475a26) into master (c721119) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5740      +/-   ##
==========================================
+ Coverage   74.10%   74.13%   +0.03%     
==========================================
  Files         408      408              
  Lines       36844    36925      +81     
  Branches     4526     4526              
==========================================
+ Hits        27302    27376      +74     
- Misses       9542     9549       +7     
Flag Coverage Δ *Carryforward flag
nightly 75.68% <100.00%> (ø) Carriedforward from c721119
unit 53.17% <100.00%> (+<0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/associations/lib/rules_level2b.py 94.73% <100.00%> (-1.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c721119...fd621d0. Read the comment docs.

@tapastro tapastro merged commit ed2efef into spacetelescope:master Feb 12, 2021
@tapastro tapastro deleted the jp-1876-nrslampimage-assocrule branch February 12, 2021 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NRS_LAMP with OPMODE==IMAGE should get Level2 image processing.
2 participants