Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable cross-dichroics in cube_build #5722

Merged
merged 3 commits into from
Feb 17, 2021

Conversation

drlaw1558
Copy link
Collaborator

As part of implementing cross-dichroic support in spec2 I realized that in addition to simple reference file updates cube_build also required a few code updates to know how to handle cross-dichroic BAND keywords. These seemed pretty simple, so this PR implements the necessary changes. Tested the new code with the new cubepar to be delivered to CRDS and it successfully builds cross-dichroic data cubes in spec2 and standalone cube build, both internal_cal and regular coordinate frames.

Tagging @jemorrison to verify whether I got anything wrong!

@codecov
Copy link

codecov bot commented Feb 6, 2021

Codecov Report

Merging #5722 (dec92ec) into master (43fbf2d) will increase coverage by 0.14%.
The diff coverage is 90.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5722      +/-   ##
==========================================
+ Coverage   75.56%   75.71%   +0.14%     
==========================================
  Files         406      406              
  Lines       35473    36177     +704     
==========================================
+ Hits        26806    27392     +586     
- Misses       8667     8785     +118     
Flag Coverage Δ *Carryforward flag
nightly 75.57% <80.69%> (ø) Carriedforward from 43fbf2d
unit 54.50% <88.03%> (+0.56%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/cube_build/ifu_cube.py 73.13% <22.22%> (-3.56%) ⬇️
jwst/cube_build/instrument_defaults.py 91.57% <99.61%> (+1.37%) ⬆️
jwst/cube_build/cube_build.py 78.75% <100.00%> (+0.61%) ⬆️
jwst/cube_build/cube_build_step.py 65.48% <100.00%> (-0.71%) ⬇️
jwst/cube_build/file_table.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43fbf2d...dec92ec. Read the comment docs.

Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me, but I'm no cube_build expert.

Copy link
Collaborator

@jemorrison jemorrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. I just checked CRDS you already have the new cubepars reference file loaded with these new options.
Great.

@hbushouse hbushouse merged commit a046fb5 into spacetelescope:master Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants