-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable cross-dichroics in cube_build #5722
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5722 +/- ##
==========================================
+ Coverage 75.56% 75.71% +0.14%
==========================================
Files 406 406
Lines 35473 36177 +704
==========================================
+ Hits 26806 27392 +586
- Misses 8667 8785 +118
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me, but I'm no cube_build expert.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine. I just checked CRDS you already have the new cubepars reference file loaded with these new options.
Great.
As part of implementing cross-dichroic support in spec2 I realized that in addition to simple reference file updates cube_build also required a few code updates to know how to handle cross-dichroic BAND keywords. These seemed pretty simple, so this PR implements the necessary changes. Tested the new code with the new cubepar to be delivered to CRDS and it successfully builds cross-dichroic data cubes in spec2 and standalone cube build, both internal_cal and regular coordinate frames.
Tagging @jemorrison to verify whether I got anything wrong!