Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-1875: Make _get_wcs_values_from_siaf function public for JSDP use #5669

Merged

Conversation

tapastro
Copy link
Contributor

Resolves JP-1875
Resolves #5663

Also changed _EngDB_Value to EngDB_Value, per ticket comment request.

@codecov
Copy link

codecov bot commented Jan 26, 2021

Codecov Report

Merging #5669 (7344aa8) into master (672c983) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5669   +/-   ##
=======================================
  Coverage   74.34%   74.34%           
=======================================
  Files         416      416           
  Lines       38110    38110           
  Branches     5000     5000           
=======================================
  Hits        28333    28333           
  Misses       9777     9777           
Flag Coverage Δ *Carryforward flag
nightly 75.88% <100.00%> (ø) Carriedforward from 672c983
unit 54.17% <100.00%> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/lib/engdb_tools.py 100.00% <100.00%> (ø)
jwst/lib/set_telescope_pointing.py 89.45% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 672c983...ac6b194. Read the comment docs.

Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just needs a change log entry.

@tapastro tapastro merged commit e28a2ad into spacetelescope:master Jan 26, 2021
@tapastro tapastro deleted the jp-1875-rename-get-wcs-from-siaf branch January 26, 2021 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make _get_wcs_values_from_siaf Function Public
3 participants