Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JWSTDMS-410 Asn_Lv2NRSLAMPSpectral: Break out the negative cases #5635

Merged
merged 3 commits into from
Jan 18, 2021

Conversation

stscieisenhamer
Copy link
Collaborator

Original test hid bug in how the constraints were setup. New case using JW00620, which covers a number of different LAMP modes, has been added to the regression.

Note: When this PR is merged, the regression data found in jwst-pipeline/jwstdms-420-nolamp/associations need to replace development data dev/associations.

@stscieisenhamer stscieisenhamer added bug associations sdp Bugs arising due to SDP testing labels Jan 18, 2021
@stscieisenhamer stscieisenhamer self-assigned this Jan 18, 2021
@codecov
Copy link

codecov bot commented Jan 18, 2021

Codecov Report

Merging #5635 (6bcfaea) into master (a54efd3) will decrease coverage by 20.14%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #5635       +/-   ##
===========================================
- Coverage   74.46%   54.31%   -20.15%     
===========================================
  Files         416      415        -1     
  Lines       38109    38103        -6     
  Branches     5106        0     -5106     
===========================================
- Hits        28378    20696     -7682     
- Misses       9731    17407     +7676     
Flag Coverage Δ *Carryforward flag
nightly 18.51% <ø> (-57.49%) ⬇️ Carriedforward from b81a4fb
unit 54.17% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/associations/lib/rules_level2b.py 96.38% <ø> (ø)
jwst/tests/helpers.py 0.00% <0.00%> (-92.31%) ⬇️
jwst/cube_build/blot_cube_build.py 7.96% <0.00%> (-92.04%) ⬇️
jwst/skymatch/skymatch.py 7.47% <0.00%> (-85.06%) ⬇️
jwst/ami/ami_average.py 17.24% <0.00%> (-82.76%) ⬇️
jwst/pipeline/calwebb_ami3.py 17.07% <0.00%> (-76.83%) ⬇️
jwst/coron/stack_refs.py 21.42% <0.00%> (-75.00%) ⬇️
jwst/extract_1d/extract_1d_step.py 8.69% <0.00%> (-72.83%) ⬇️
jwst/ami/instrument_data.py 16.90% <0.00%> (-71.84%) ⬇️
jwst/refpix/irs2_subtract_reference.py 12.45% <0.00%> (-71.18%) ⬇️
... and 141 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a54efd3...6bcfaea. Read the comment docs.

@hbushouse hbushouse merged commit 38cb850 into spacetelescope:master Jan 18, 2021
@stscieisenhamer
Copy link
Collaborator Author

I am moving the appropriate artifactory data now.

@hbushouse
Copy link
Collaborator

Thanks. I tried doing the move yesterday, but it's not obvious that it got moved properly or that I moved/copied the right stuff.

@hbushouse hbushouse added this to the Build 7.7 milestone Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
associations bug sdp Bugs arising due to SDP testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants