Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-1848: Schema updates for new and modified keywords #5618

Merged
merged 2 commits into from
Jan 14, 2021

Conversation

hbushouse
Copy link
Collaborator

Update datamodels schemas for all keyword changes documented in JP-1799, in order to keep our schemas in sync with the Keyword Dictionary.

Fixes #5610
Fixes JP-1848
Fixes JP-1849

@hbushouse hbushouse added datamodels keywords Anything related to FITS header keywords labels Jan 13, 2021
@hbushouse hbushouse added this to the Build 7.7 milestone Jan 13, 2021
@hbushouse
Copy link
Collaborator Author

When merged this will of course cause horrific numbers of failures in regression tests, due to keyword changes that will affect the headers of nearly every product created.

@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #5618 (22a41be) into master (2bbb677) will decrease coverage by 0.31%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5618      +/-   ##
==========================================
- Coverage   74.44%   74.13%   -0.32%     
==========================================
  Files         416      416              
  Lines       38199    38380     +181     
  Branches     5201     5201              
==========================================
+ Hits        28438    28452      +14     
- Misses       9761     9928     +167     
Flag Coverage Δ *Carryforward flag
nightly 75.98% <100.00%> (ø) Carriedforward from 0d2e34e
unit 54.14% <0.00%> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/cube_build/ifu_cube.py 68.16% <80.00%> (-8.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bbb677...22a41be. Read the comment docs.

Copy link
Collaborator

@jdavies-st jdavies-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I doubt this will have any effect on our regression tests, given the keywords involved and that we're simply expanding the enum for some more commonly-used ones.

@hbushouse
Copy link
Collaborator Author

Looks good. I doubt this will have any effect on our regression tests, given the keywords involved and that we're simply expanding the enum for some more commonly-used ones.

Unfortunately there's at least 1 existing keyword that has had a slight modification to its comment/title field, so I suspect that will in fact lead to many failures. But hey, that's what okify_regtests is for, right?

@hbushouse hbushouse merged commit e77621a into spacetelescope:master Jan 14, 2021
@hbushouse hbushouse deleted the jp1848 branch January 14, 2021 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datamodels keywords Anything related to FITS header keywords
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes to enum lists in keyword schemas
2 participants