Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused LinearPipeline class #5590

Merged

Conversation

eslavich
Copy link
Collaborator

@eslavich eslavich commented Jan 5, 2021

This removes the LinearPipeline class, which is a simplified base class for pipelines whose steps can feed output into one another without requiring additional Python glue code. In practice all pipelines have required at least some glue, so the simplified base class was never used. I'd like to remove it so that we don't have to maintain it in the new stpipe package.

I'll create a ticket to remove the pars-linearpipeline reference type from crds.

@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #5590 (507c52e) into master (93b8d5d) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5590      +/-   ##
==========================================
+ Coverage   74.39%   74.43%   +0.04%     
==========================================
  Files         416      417       +1     
  Lines       38088    38175      +87     
  Branches     5637     5637              
==========================================
+ Hits        28336    28417      +81     
- Misses       9752     9758       +6     
Flag Coverage Δ *Carryforward flag
nightly 75.93% <100.00%> (ø) Carriedforward from 28f5fae
unit 54.49% <100.00%> (-0.07%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/stpipe/utilities.py 95.37% <ø> (+0.37%) ⬆️
jwst/lib/suffix.py 100.00% <100.00%> (+4.00%) ⬆️
jwst/pipeline/__init__.py 100.00% <100.00%> (ø)
jwst/stpipe/__init__.py 100.00% <100.00%> (ø)
jwst/combine_1d/combine1d.py 88.64% <0.00%> (-0.38%) ⬇️
jwst/datamodels/__init__.py 100.00% <0.00%> (ø)
jwst/datamodels/multicombinedspec.py 66.66% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93b8d5d...507c52e. Read the comment docs.

Copy link
Collaborator

@jdavies-st jdavies-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just needs a change log entry before merging.

@hbushouse hbushouse added this to the Build 7.7 milestone Jan 6, 2021
@eslavich eslavich merged commit 7298276 into spacetelescope:master Jan 7, 2021
@eslavich eslavich deleted the eslavich-remove-linear-pipeline branch January 7, 2021 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants