Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-1212: NIRSpec MOS spec3 regtest #4410

Merged
merged 1 commit into from
Dec 30, 2019

Conversation

hbushouse
Copy link
Collaborator

Resolves #4403 and https://jira.stsci.edu/browse/JP-1212

calwebb_spec3 test on NIRSpec MOS data. Used 3-point dither pattern of simulated MOS images (for both detectors) and embedded the images in SDP files from jw00626 obs30. The MSA metadata file is chopped down to contain only 6 sources, 3 of which result in data on the NRS2 detector (all 6 have data on NRS1), with a mixture of point vs extended source designations and one dedicated background shutter (slitlet #8) thrown in for good measure. The 6 input _cal products result in 6 source-based results, each of which has a cal, crf, s2d, and x1d product. All 24 resulting products are tested.

Inputs and truth files have been uploaded to artifactory.

@hbushouse hbushouse added this to the Build 7.5 milestone Dec 30, 2019
@codecov
Copy link

codecov bot commented Dec 30, 2019

Codecov Report

Merging #4410 into master will decrease coverage by 11.27%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #4410       +/-   ##
===========================================
- Coverage   62.99%   51.72%   -11.28%     
===========================================
  Files         398      398               
  Lines       34522    34522               
  Branches     5337     5337               
===========================================
- Hits        21748    17857     -3891     
- Misses      11285    15573     +4288     
+ Partials     1489     1092      -397
Flag Coverage Δ
#newnightly ?
#unit 51.72% <ø> (ø) ⬆️
Impacted Files Coverage Δ
jwst/rscd/rscd_sub.py 4.68% <0%> (-85.94%) ⬇️
jwst/coron/klip.py 14.63% <0%> (-82.93%) ⬇️
jwst/ami/ami_average.py 17.24% <0%> (-82.76%) ⬇️
jwst/wfs_combine/wfs_combine.py 13.87% <0%> (-80.87%) ⬇️
jwst/resample/resample.py 18.18% <0%> (-76.14%) ⬇️
jwst/coron/stack_refs.py 21.42% <0%> (-71.43%) ⬇️
jwst/wfs_combine/wfs_combine_step.py 30% <0%> (-70%) ⬇️
jwst/skymatch/skymatch.py 7.42% <0%> (-68%) ⬇️
jwst/pipeline/calwebb_tso3.py 18.18% <0%> (-66.24%) ⬇️
jwst/pipeline/calwebb_ami3.py 19.23% <0%> (-65.39%) ⬇️
... and 98 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c390bd...10715a9. Read the comment docs.

@hbushouse hbushouse merged commit 0af0adc into spacetelescope:master Dec 30, 2019
@hbushouse hbushouse deleted the test_mos3 branch December 30, 2019 23:31
@hbushouse hbushouse modified the milestones: Build 7.5, Build 7.4.2 Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REGTEST: Write new NIRSpec MOS level3 regression test
2 participants