JP-3223: Extract_2d 'slit_name' parameter fails for NRS_MSASPEC slits (…

…#8272)

Co-authored-by: Howard Bushouse <[email protected]>

CHANGES.rst

@@ -42,7 +42,14 @@ extract_1d
 
 - Added a hook to bypass the ``extract_1d`` step for NIRISS SOSS data in 
   the FULL subarray with warning. [#8225]
-
+
+extract_2d
+----------
+
+- Fixed crash when user provides an integer value for the `slit_name` argument,
+  by converting to a string. This change had been done in #8108, but it got undone
+  by another PR. [#8272]
+
 outlier_detection
 -----------------
 
@@ -219,9 +226,6 @@ extract_2d
   be passed as a string, e.g. slit_name='67'. Included this
   in the corresponding documentation. [#8081]
 
-- Fixed potential future crash if MSA slitlet name is not an
-  integer. [#8108]
-
 general
 -------
 

jwst/extract_2d/nirspec.py

@@ -46,12 +46,9 @@ def nrs_extract2d(input_model, slit_name=None):
     open_slits = slit2msa.slits[:]
     if slit_name is not None:
         new_open_slits = []
-        if not isinstance(slit_name, str):
-            slit_name = str(slit_name)
+        slit_name = str(slit_name)
         for sub in open_slits:
-            if not isinstance(sub.name, str):
-                str_subnme = str(sub.name)
-            if str_subnme == slit_name:
+            if str(sub.name) == slit_name:
                 new_open_slits.append(sub)
                 break
         if len(new_open_slits) == 0: