Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include data units in plot axes #191

Merged
merged 3 commits into from
Jul 16, 2020
Merged

Include data units in plot axes #191

merged 3 commits into from
Jul 16, 2020

Conversation

javerbukh
Copy link
Contributor

Screen Shot 2020-07-07 at 12 07 09 PM

Fixes #141

@javerbukh javerbukh requested review from nmearl and PatrickOgle July 7, 2020 16:06
@javerbukh javerbukh changed the title Include data units in plot axes WIP: Include data units in plot axes Jul 7, 2020
@javerbukh javerbukh changed the title WIP: Include data units in plot axes Include data units in plot axes Jul 8, 2020
nmearl
nmearl reviewed Jul 8, 2020
View reviewed changes
@javerbukh javerbukh force-pushed the access_plot_units branch 2 times, most recently from 68baedf to d5aab6a Compare July 10, 2020 14:13
@javerbukh javerbukh requested a review from duytnguyendtn July 10, 2020 14:38
nmearl
nmearl previously approved these changes Jul 12, 2020
View reviewed changes
nmearl
nmearl reviewed Jul 13, 2020
View reviewed changes
Copy link
Contributor

@nmearl nmearl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear to me what you're using to trigger the plot axis unit setting? This doesn't seem to Just Work ™️ , and from the code, it's not obvious that it's integrated with any of the plotting functions (except the remove data method).

@nmearl nmearl self-requested a review July 13, 2020 14:14
@nmearl nmearl dismissed their stale review July 13, 2020 14:14

Requires follow-up.

@javerbukh
Copy link
Contributor Author

_set_plot_axes_labels() is called at the end of _update_selected_data_items(), which is called in add_data_to_viewer() and remove_data_from_viewer(). So the plot labels are updated to the most recently active data any time data has been added or removed.

eteq
eteq approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@eteq eteq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor suggestions but overall looking good!

@javerbukh javerbukh force-pushed the access_plot_units branch from d5aab6a to 8fa1717 Compare July 15, 2020 20:05
@eteq eteq merged commit 5759083 into spacetelescope:master Jul 16, 2020
@eteq
Copy link
Contributor

eteq commented Jul 16, 2020

Thanks @javerbukh !

@rosteen rosteen mentioned this pull request Jul 29, 2020
Closed
@kecnry kecnry mentioned this pull request Oct 14, 2022
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eteq eteq eteq approved these changes

@nmearl nmearl nmearl approved these changes

@PatrickOgle PatrickOgle Awaiting requested review from PatrickOgle

@duytnguyendtn duytnguyendtn Awaiting requested review from duytnguyendtn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Have the axis marks not overlap with the numbers on the plot
3 participants
@javerbukh @eteq @nmearl