Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix baby shark loading in Imviz concept notebook for image slices #1772

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Oct 24, 2022

Description

I didn't realize some frames come back as 3D in itself (RGB). We would want to convert those to gray first before displaying.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set?
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

in Imviz concept notebook for image slices.
@pllim pllim added bug Something isn't working imviz trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Oct 24, 2022
@pllim pllim added this to the 3.1 milestone Oct 24, 2022
@github-actions github-actions bot added the documentation Explanation of code and concepts label Oct 24, 2022
Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👶 🦈

@pllim pllim merged commit 6f2e5d7 into spacetelescope:main Oct 24, 2022
@pllim pllim deleted the fix-baby-shark-concept branch October 24, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Explanation of code and concepts imviz no-changelog-entry-needed changelog bot directive trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants