HLA-1448: Fix the crfactor designation for the WFPC2 detector to avoid failure #1969
+158
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed the the computation for rejecting catalog creation based on expected cosmic ray detections to fail ONLY for WFPC2. Also, updated the WFPC2 cr_residual factor from 0.0 to 0.05 as it had never be set correctly. Created a PyTest for WFPC2 SVM processing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves HLA-1448
Closes #
Fixed the crfactor designation for the WFPC2 detector (PC) which caused the the computation for rejecting catalog creation based on expected cosmic ray detections to fail ONLY for WFPC2. Also, updated the WFPC2 cr_residual factor from 0.0 to 0.05 as it had never be set correctly. Created a PyTest for WFPC2 SVM processing.
Checklist for maintainers
CHANGELOG.rstwithin the relevant release section