Updates to scripts #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will take a look and get back to you |
Ran |
nkasmanoff
reviewed
Dec 10, 2023
nkasmanoff
reviewed
Dec 10, 2023
|
@jejjohnson left some comments with minor changes that may reduce duplicate code. Imo not a blocker to merging, I can branch off of the spaceml version of this and update later on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nkasmanoff If possible, can you run the refactored SDO downloader and see if it works on your end? I still get the 408 errors which I still think is something server-side (or perhaps my VPN).