Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve profiler instructions #318

Merged
merged 5 commits into from
Aug 29, 2024
Merged

Improve profiler instructions #318

merged 5 commits into from
Aug 29, 2024

Conversation

hasanza
Copy link
Contributor

@hasanza hasanza commented Jul 30, 2024

This PR fixes and improves the profiler tool instructions. Additional info like how to download and run the profiler tool, what each of commands does, and what each of the options does has also been added.

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.15%. Comparing base (e320b1f) to head (8deaacc).
Report is 55 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #318      +/-   ##
==========================================
- Coverage   94.18%   94.15%   -0.03%     
==========================================
  Files          27       27              
  Lines        3386     3387       +1     
==========================================
  Hits         3189     3189              
- Misses        197      198       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@poszu poszu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you unintentionally included .DS_store files and the changes in Cargo.lock.

docs/profiler.md Outdated Show resolved Hide resolved
docs/profiler.md Outdated Show resolved Hide resolved
docs/profiler.md Outdated Show resolved Hide resolved
docs/profiler.md Outdated Show resolved Hide resolved
profiler/.DS_Store Outdated Show resolved Hide resolved
@poszu poszu self-requested a review August 29, 2024 09:49
@poszu poszu enabled auto-merge (squash) August 29, 2024 10:11
@poszu poszu merged commit 9eec86e into main Aug 29, 2024
21 checks passed
@poszu poszu deleted the add-profiler-instructions branch August 29, 2024 11:05
acud pushed a commit that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants