Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - api: v2alpha1: add total field to all List responses #6049

Closed
wants to merge 6 commits into from

Conversation

kacpersaw
Copy link
Contributor

Add field with total count of records for accounts, atxs, layers, rewards and transactions.

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 76.81159% with 16 lines in your changes missing coverage. Please review.

Project coverage is 81.4%. Comparing base (fa21ad1) to head (3fadee6).

Files Patch % Lines
api/grpcserver/v2alpha1/account.go 50.0% 2 Missing and 2 partials ⚠️
api/grpcserver/v2alpha1/activation.go 50.0% 2 Missing and 2 partials ⚠️
api/grpcserver/v2alpha1/layer.go 50.0% 2 Missing and 2 partials ⚠️
api/grpcserver/v2alpha1/reward.go 60.0% 1 Missing and 1 partial ⚠️
api/grpcserver/v2alpha1/transaction.go 60.0% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #6049     +/-   ##
=========================================
- Coverage     81.4%   81.4%   -0.1%     
=========================================
  Files          299     299             
  Lines        31999   32054     +55     
=========================================
+ Hits         26071   26109     +38     
- Misses        4230    4241     +11     
- Partials      1698    1704      +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kacpersaw
Copy link
Contributor Author

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Jun 19, 2024
Add field with total count of records for accounts, atxs, layers, rewards and transactions.
@spacemesh-bors
Copy link

Build failed:

@kacpersaw
Copy link
Contributor Author

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Jun 19, 2024
Add field with total count of records for accounts, atxs, layers, rewards and transactions.
@spacemesh-bors
Copy link

Build failed:

@kacpersaw
Copy link
Contributor Author

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Jun 19, 2024
Add field with total count of records for accounts, atxs, layers, rewards and transactions.
@spacemesh-bors
Copy link

Build failed:

@kacpersaw
Copy link
Contributor Author

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Jun 19, 2024
Add field with total count of records for accounts, atxs, layers, rewards and transactions.
@spacemesh-bors
Copy link

Pull request successfully merged into develop.

Build succeeded:

@spacemesh-bors spacemesh-bors bot changed the title api: v2alpha1: add total field to all List responses [Merged by Bors] - api: v2alpha1: add total field to all List responses Jun 19, 2024
@spacemesh-bors spacemesh-bors bot closed this Jun 19, 2024
@spacemesh-bors spacemesh-bors bot deleted the v2alpha1-total-field branch June 19, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants