fix: Changed disable_container_credentials default to true

[sephriot]

Description of the change

Clickup ticket: https://app.clickup.com/t/8695rkt6f

Goal: change the default setting to a value that guarantees secure environment.

Type of change

• Bug fix (non-breaking change that fixes an issue);
• New feature (non-breaking change that adds functionality);
• Breaking change (fix or feature that would cause existing functionality to not work as expected);
• Documentation (a documentation or example fix not affecting the infrastructure managed by this module);

Checklists

Development

• All necessary variables have been defined, with defaults if applicable;
• The code is formatted properly;

Code review

• The module version is bumped accordingly;
• Spacelift tests are passing;
• This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached;
• This pull request is no longer marked as "draft";
• Reviewers have been assigned;
• Changes have been reviewed by at least one other engineer;

[mwasilew2]

don't have enough context on this one

[michieldewilde]

I don't have any context on this as well.
Can you please add some additional information in the pull request description @sephriot

[sephriot]

I don't have any context on this as well. Can you please add some additional information in the pull request description @sephriot

Damn clickup wasn't linked.

[sephriot]

@michieldewilde @mwasilew2 PR updated.

[michieldewilde]

@sephriot Should this not be a major release? I base this on the description of the ticket that mentions that this could be a breaking change for some users?

[sephriot]

@sephriot Should this not be a major release? I base this on the description of the ticket that mentions that this could be a breaking change for some users?

I'd say we can bump it up to minor release instead patch if you are concerned.
It is not a breaking change, best case a backward compatible one.