Sanitize admin UI input for role bans #35422
Open
+11
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Killerqu00
requested review from
DrSmugleaf,
nikthechampiongr and
crazybrain23
as code owners
github-actions
bot
added
S: Needs Review
|
is the problem that the command autocompletes to other roles? |
the problem is that roleban UI has antag roles, even though antag bans aren't a thing. this results in antag being passed to CreateRoleBan as a role, and then it just fails because it's not an actual job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
fixes #35266 (after the issue changes)
Why / Balance
Technical details
Media
Requirements
Breaking changes
Changelog