Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lattice tiles footsteps now sound like catwalks #35421

Merged
merged 1 commit into from
Feb 23, 2025
Merged

Lattice tiles footsteps now sound like catwalks #35421

merged 1 commit into from
Feb 23, 2025

Conversation

K-Dynamic
Copy link
Contributor

About the PR

  • Lattice tiles footsteps now sound like catwalks

Why / Balance

Based on what tg station did (tgstation/tgstation#84917) and makes lattices sound like catwalks when walked over.

This should improve player immersion as it was jarring to hear normal tile sounds when walking off from catwalks over lattices, despite the two being closely associated.

Technical details

yml change only

Media

N/A

Requirements

Breaking changes

N/A

Changelog

🆑

  • tweak: Lattice tiles footsteps now sound like catwalks.

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. size/XS Denotes a PR that changes 0-9 lines. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Feb 23, 2025
PJB3005
PJB3005 approved these changes Feb 23, 2025
View reviewed changes
Copy link
Member

@PJB3005 PJB3005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change

@PJB3005 PJB3005 added S: Needs Review Status: Requires additional reviews before being fully accepted S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. D3: Low Difficulty: Some codebase knowledge required. labels Feb 23, 2025
@slarticodefast slarticodefast merged commit 17218b7 into space-wizards:master Feb 23, 2025
14 checks passed
@K-Dynamic
Copy link
Contributor Author

I would've adjusted the volume parameter because they're still hard to hear, except tiles aren't entities :trollface:

@deltanedas
Copy link
Contributor

robin hood steal from the tg give to the tg14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PJB3005 PJB3005 PJB3005 approved these changes

@slarticodefast slarticodefast slarticodefast approved these changes

Assignees
No one assigned
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item. D3: Low Difficulty: Some codebase knowledge required. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Review Status: Requires additional reviews before being fully accepted size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@K-Dynamic @deltanedas @PJB3005 @slarticodefast