[HOTFIX] Antag ban fix

[Killerqu00]

About the PR

fixes #35266
hopefully I am doing a hotfix properly this time

Why / Balance

Technical details

Nukeops isn't a job

Media

server in dev doesn't crash anymore so that's a win, I guess

Requirements

• I have read and am following the Pull Request and Changelog Guidelines.
• I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

[slarticodefast]

Why are both of these prototypes handled by a single id string by the way? That looks a little sus.

[Killerqu00]

Why are both of these prototypes handled by a single id string by the way? That looks a little sus.

wish i knew

[Errant-4]

Updating severity to P0 Critical, as per issue

[PJB3005]

This doesn't make any sense. The function is still adding the Job: prefix to the role name, so this would just create invalid database data.

[Killerqu00]

This doesn't make any sense. The function is still adding the Job: prefix to the role name, so this would just create invalid database data.

the antag bans aren't even real from the looks of it (#29730 is closed). i can just make it so it ignores the antag bans instead of throwing in order to prevent database pollution

[PJB3005]

This should be getting validated (and logged) by the UI that allows admins to place bans instead.

[PJB3005]

Given that antag bans clearly aren't even a thing at all I'm gonna change the original issue description and lower the priority. I suspect the "server crashes" is just a thing caught by exception tolerance so it's not too important.

Probably best to make this not a hotfix anymore but you can do whateevr.

[Killerqu00]

sure, I'll make a separate PR for this then