-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to Hydroponic sprites #35004
base: master
Are you sure you want to change the base?
Updates to Hydroponic sprites #35004
Conversation
RSI Diff Bot; head commit 1b6afa1 merging into 082b1f8 Resources/Textures/Objects/Specific/Hydroponics/aloe.rsi
Resources/Textures/Objects/Specific/Hydroponics/apple.rsi
Resources/Textures/Objects/Specific/Hydroponics/banana.rsi
Resources/Textures/Objects/Specific/Hydroponics/blood_tomato.rsi
Resources/Textures/Objects/Specific/Hydroponics/blue_tomato.rsi
Resources/Textures/Objects/Specific/Hydroponics/cherry.rsi
Resources/Textures/Objects/Specific/Hydroponics/chili.rsi
Resources/Textures/Objects/Specific/Hydroponics/chilly.rsi
Resources/Textures/Objects/Specific/Hydroponics/eggy.rsi
Resources/Textures/Objects/Specific/Hydroponics/fly_amanita.rsi
Resources/Textures/Objects/Specific/Hydroponics/golden_apple.rsi
Resources/Textures/Objects/Specific/Hydroponics/grape.rsi
Resources/Textures/Objects/Specific/Hydroponics/holymelon.rsi
Resources/Textures/Objects/Specific/Hydroponics/lemon.rsi
Resources/Textures/Objects/Specific/Hydroponics/lily.rsi
Resources/Textures/Objects/Specific/Hydroponics/lime.rsi
Resources/Textures/Objects/Specific/Hydroponics/meatwheat.rsi
Resources/Textures/Objects/Specific/Hydroponics/oat.rsi
Resources/Textures/Objects/Specific/Hydroponics/orange.rsi
Resources/Textures/Objects/Specific/Hydroponics/pineapple.rsi
Resources/Textures/Objects/Specific/Hydroponics/poppy.rsi
Resources/Textures/Objects/Specific/Hydroponics/pumpkin.rsi
Resources/Textures/Objects/Specific/Hydroponics/rice.rsi
Resources/Textures/Objects/Specific/Hydroponics/sugarcane.rsi
Resources/Textures/Objects/Specific/Hydroponics/tomato.rsi
Resources/Textures/Objects/Specific/Hydroponics/watermelon.rsi
Resources/Textures/Objects/Specific/Hydroponics/wheat.rsi
|
You might want to adjust the meatwheat sprite as well since it is the same as for normal wheat, but in red. |
that pineapple looks MOUTH-WATERING, I do have some critiques though:
regardless I think its fair to say these sprites in general are much better, good job! |
Thank you for the feed back! |
Made the adjustments to aloe, apple, corn and wheat. You were right about the apple lol, the colour was nuts. Let me know how you like the differences |
The meatwheat plant stages should be adjusted as well, they are a simple recoloring of the old ones for the wheat plant. |
Will do, plan to do more changes after work |
Those sprites look amazing, great work. |
Thank you :) |
I love them! the apple's colours definitely look like a step up, and the aloe looks SO much better, some last comments however:
once more, awesome work! hope to see this merged |
could you address this one ⬆️ as well? even if you were to be against its recolouring I wanted to know your thoughts on it 👍
I see, they do look much better though! no issues here 👍
alas the terrors of spriting, one night it looks great and the very next morning you have to redo something entirely, we're our own greatest critics, regardless it looks much better now! I have however been thinking and I think the part that "holds" them both together could be made slightly lower than in the middle, let me know what you think
I see, makes sense as I wouldn't call the ambrosia's sprites faulty in any way either, though it could prove to be in an inconsistent style if this were to be merged, but it should be a non-issue
glad to know! :)
the watermelon looks great! but I think its cut sprite and full sprite are a bit unrelated, either of the two could be or smaller (to accommodate for the cut variant) or bigger (to accommodate for the full variant), personally I would do the latter, as I think it'd make sense to have the watermelon be bigger in its sprite than most other plants! (I also think it needs some more darkening, since at the moment it looks very "gem-like", a nitpick, though) put some stuff down, awesome work you've done, kudos! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you didn't change sprites like 'seed' then the attribution needs to stay for those.
Better now hopefully? |
Resources/Textures/Objects/Specific/Hydroponics/aloe.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/Objects/Specific/Hydroponics/apple.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/Objects/Specific/Hydroponics/banana.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/Objects/Specific/Hydroponics/blood_tomato.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/Objects/Specific/Hydroponics/blue_tomato.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/Objects/Specific/Hydroponics/meatwheat.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/Objects/Specific/Hydroponics/pumpkin.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/Objects/Specific/Hydroponics/tomato.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/Objects/Specific/Hydroponics/watermelon.rsi/dead.png
Outdated
Show resolved
Hide resolved
Resources/Textures/Objects/Specific/Hydroponics/wheat.rsi/meta.json
Outdated
Show resolved
Hide resolved
@ArtisticRoomba Okay! Everything should be good now, sorry for the first timer incompetence |
you're fine, these types of things are the only thing I can review in the repo (godo) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I promise we're almost done
Resources/Textures/Objects/Specific/Hydroponics/cherry.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/Objects/Specific/Hydroponics/sugarcane.rsi/meta.json
Outdated
Show resolved
Hide resolved
LOL, I can only blame myself. Okay, now.. Now everything should be amazing and flawless.. right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aaaand we're all good now! Thank you for doing all of this amazing spritework, these really are amazing.
Sprites will need art maintainer approval, and obviously this will need a second lookover from an actual maintainer.
Brilliant! You're welcome, and thank you for putting up with all of that. |
as it's all related sprites (ie. botany plants) I'm confident It's fine to just keep pumping them, the only issue I can see is that the more you re-sprite the higher the chances the art maintainers will find something amiss, but given that the sprites are huge step-ups from previously it probably won't happen too much, if you want to give it a final check before sending it to the art maintainers' way (Since their approval is the most important) you can also ask people such as ArtisticRoomba, ps3moira or really just anyone that oftentimes delves in spritework to do it. Art maintainers are Emisse and Ubaser by the way, unsure if there's anyone else on that team 🤔 |
Yeah I think that's what I'm worried about, that they might find a lot that they dislike about them and I'll have to re-do a lot of it. |
@slarticodefast Heelloo, I need help. Then I tried to go back to the old egg-plant seed packet and it's just gone forever. |
Do the sprite states exist in the meta.json? The images need to remain the same name as the state name |
Yeah. I've re-done the sprites for all stages, harvest as well but the only thing that shows up ingame is the regular egg produce. And I can't test if the rest of the stages work because of the missing seed packet. I'm in egg based hell. Update: |
my grape produce is pissing me off a little bit idk what to do about it @ArtisticRoomba I think it can be reviewed again now, also for art approval is there anyone I can @ for that or shall I just wait? |
you can ping Ubaser or Emisse for art approval, you'll also need a second maintainer to review the code but it should be pretty quick (I'd recommend beck-thompson or Slartcodefast!) |
About the PR
Updated some sprites for a bunch of plants in botany.
Why / Balance
I feel that the sprites for some plants/fruit needed to be updated to some degree.
Technical details
Media
Requirements
Breaking changes
Changelog