Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOTFIX Admin playerlist character update fix #34560

Merged
merged 1 commit into from
Jan 21, 2025
Merged

HOTFIX Admin playerlist character update fix #34560

merged 1 commit into from
Jan 21, 2025

Conversation

Errant-4
Copy link
Member

About the PR

Identity changes were not properly tracked by AdminSystem, and were not shown on the player panel until unrelated systems update PlayerInfo. All characters also listed [identity] after their names (which is the default name of a mob's Identity entity, and then it's immediate roundstart update would never show up)
Shoutout to Milon for his help with the investigation

Why / Balance

Obvious bug

Technical details

The IdentityChanged event was subscribed to as if it was a broadcast event, but not raised as such. Changed subscription to match, since it was immediately checking for ActorComponent anyway

Media

identity_fix.mp4

Requirements

Changelog
🆑 Errant
ADMIN:

  • fix: The admin window playerlist now properly tracks identity changes again.

@github-actions github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/S Denotes a PR that changes 10-99 lines. labels Jan 21, 2025
@Errant-4 Errant-4 added T: Bugfix Type: Bugs and/or bugfixes P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. D3: Low Difficulty: Some codebase knowledge required. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. A: Admin Tooling Area: Admin tooling and moderation. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 21, 2025
@Errant-4 Errant-4 changed the base branch from master to stable January 21, 2025 21:23
@Errant-4 Errant-4 changed the title Admin playerlist character update fix HOTFIX Admin playerlist character update fix Jan 21, 2025
@Errant-4 Errant-4 added the Branch: Stable Intended to be merged into Stable. label Jan 21, 2025
slarticodefast
slarticodefast approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, works as intended!

@slarticodefast slarticodefast self-assigned this Jan 21, 2025
@slarticodefast slarticodefast merged commit ae21306 into space-wizards:stable Jan 21, 2025
17 checks passed
@slarticodefast slarticodefast mentioned this pull request Jan 21, 2025
Merged
@Errant-4 Errant-4 deleted the identity branch January 22, 2025 07:06
widgetbeck pushed a commit to widgetbeck/imp-station-14 that referenced this pull request Jan 29, 2025
@Errant-4 @widgetbeck
HOTFIX Admin playerlist character update fix (space-wizards#34560)
bf67d2d 
fix IdentityChangedEvent subscription
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Simyon264 Simyon264 Simyon264 approved these changes

@slarticodefast slarticodefast slarticodefast approved these changes

@DrSmugleaf DrSmugleaf Awaiting requested review from DrSmugleaf DrSmugleaf is a code owner

@nikthechampiongr nikthechampiongr Awaiting requested review from nikthechampiongr nikthechampiongr is a code owner

@crazybrain23 crazybrain23 Awaiting requested review from crazybrain23 crazybrain23 is a code owner

Assignees

@slarticodefast slarticodefast

Labels
A: Admin Tooling Area: Admin tooling and moderation. Branch: Stable Intended to be merged into Stable. D3: Low Difficulty: Some codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Review Status: Requires additional reviews before being fully accepted size/S Denotes a PR that changes 10-99 lines. T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Errant-4 @Simyon264 @slarticodefast