Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Power Monitoring Computer boards from research and lathe recipes. Added default engineering sprites for atmos computer boards. #34078

Merged

Conversation

Alpaccalypse
Copy link
Contributor

@Alpaccalypse Alpaccalypse commented Dec 26, 2024

About the PR

Set the default sprite for Atmospheric Alerts Computer boards and Atmospheric Network Monitoring boards to cpu_engineering. The 'power monitoring computer board' has been removed from industrial research and lathe recipes.

Why / Balance

The atmos boards defaulted to the base green sprites. The power monitoring computer can be resource intensive when used, and was not intended to be able to be researched and printed, due to this concern.

Technical details

A few lines added to and removed from the relevant industrial/lathe/computer/electronics .yml files.

Media

The boards are now yellow, screenshot for example (they are not actually printable):
{CA3B86A2-B175-40D8-97D9-0415489C8A00}

Requirements

Changelog
🆑

  • remove: Power monitoring computer boards can no longer be researched or printed, as originally intended.

…. Added research unlocks and lathe recipes for them.
@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/S Denotes a PR that changes 10-99 lines. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. labels Dec 26, 2024
@slarticodefast
Copy link
Member

I'm pretty sure these are not printable on purpose because they are very networking expensive (same as the power monitoring console).

@Alpaccalypse
Copy link
Contributor Author

I'm pretty sure these are not printable on purpose because they are very networking expensive (same as the power monitoring console).

Ahh, I thought there might have been a reason, though the power monitoring can be printed, which is why I went ahead and added these too. I acutally looked into this due to a bug I haven't been able to replicate, where I dismantled the alerts console to find the name of the board forsci to print; it didn't drop a board, so couldn't be rebuilt.

The reason I've persoanlly wanted these, was to build an all-in-one monitoring station in atmospherics, on maps where there was a lot of walking between the different alerts/monitoring stations in engineering. Hopefully there would rarely be a call to have more than one of these built as extras, though that wouldn't stop someone spamming them just for server grief I suppose, if that is an issue.

It did occur to me that they could be given a slightly higher material cost to print, than the default, as a "specialist" board.

@slarticodefast
Copy link
Member

Let me ping @metalgearsloth to get some info about the performance aspect. Not sure how problematic someone spamming them would be. The consoles can only be used by one player at a time for the same reason by the way.

@chromiumboy
Copy link
Contributor

I'm pretty sure these are not printable on purpose because they are very networking expensive (same as the power monitoring console).

Ahh, I thought there might have been a reason, though the power monitoring can be printed, which is why I went ahead and added these too. I acutally looked into this due to a bug I haven't been able to replicate, where I dismantled the alerts console to find the name of the board forsci to print; it didn't drop a board, so couldn't be rebuilt.

The reason I've persoanlly wanted these, was to build an all-in-one monitoring station in atmospherics, on maps where there was a lot of walking between the different alerts/monitoring stations in engineering. Hopefully there would rarely be a call to have more than one of these built as extras, though that wouldn't stop someone spamming them just for server grief I suppose, if that is an issue.

It did occur to me that they could be given a slightly higher material cost to print, than the default, as a "specialist" board.

If power monitoring circuit boards can be printed, that's a issue, and that recipe will need to be removed from the circuitboard printer. The atmos computers have lower network and server computational costs than power monitoring but they probably shouldn't be printable either, TBH. Destroyed consoles should always drop their respective circuitboards though, so if thats not happening it's a bug that needs to be fixed

@slarticodefast
Copy link
Member

Alright, thanks for the info, chrome. @Alpaccalypse We can still merge the sprite change, but could you remove the board lathe recipes and their research, including the power monitoring board?

@slarticodefast slarticodefast self-assigned this Dec 27, 2024
@slarticodefast slarticodefast added the S: Awaiting Changes Status: Changes are required before another review can happen label Dec 27, 2024
@Alpaccalypse
Copy link
Contributor Author

Alpaccalypse commented Dec 27, 2024

Sure. It also turns out, I can replicate that "not dropping boards from deconstructed computers" bug on live servers, just doesn't seem to hapen with latest build I was testing on, so maybe it has been fixed?

*Can't read, edited comment to remove redundant question.

@beck-thompson beck-thompson added P3: Standard Priority: Default priority for repository items. D3: Low Difficulty: Some codebase knowledge required. A: Art Area: Art with no implications for other areas. T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Dec 27, 2024
…Removed Power Monitoring Computer board from research and lathe recipes.
…onitoring Computer board from research and lathe recipes.
@Alpaccalypse
Copy link
Contributor Author

Latest version should now only add sprites for the atmos boards, and also removes Power Monitoring Computer board from research and the lathe menu. WAI when tested.

Note: Removing the line for researching Power board also included the comment #the actual solar panel itself should be in here and I am not sure what that was referring to, is it somehow important for researching and building solar panels?

@Alpaccalypse Alpaccalypse changed the title Atmospherics computer boards: sprite, research and recipes defined. Added default engineering sprites for atmos computer boards, removed Power Monitoring Computer boards from research and lathe recipes. Dec 27, 2024
Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you for your first contribution!

@slarticodefast slarticodefast added S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. and removed S: Awaiting Changes Status: Changes are required before another review can happen labels Dec 27, 2024
@Alpaccalypse Alpaccalypse changed the title Added default engineering sprites for atmos computer boards, removed Power Monitoring Computer boards from research and lathe recipes. Removed Power Monitoring Computer boards from research and lathe recipes. Added default engineering sprites for atmos computer boards. Dec 27, 2024
@slarticodefast slarticodefast merged commit a21d809 into space-wizards:master Dec 28, 2024
12 checks passed
@Alpaccalypse Alpaccalypse deleted the atmos-computer-boards-content branch January 5, 2025 12:22
@SpaceRox1244
Copy link
Contributor

Wait a minute, isnt there already a precaution to reduce the load on the server caused by the power monitoring console, since only one person at a time is allowed to use one? Last time I was playing engineering, if someone was using the console, everybody else was locked out of it.

@Alpaccalypse
Copy link
Contributor Author

Alpaccalypse commented Jan 6, 2025

Wait a minute, isnt there already a precaution to reduce the load on the server caused by the power monitoring console, since only one person at a time is allowed to use one? Last time I was playing engineering, if someone was using the console, everybody else was locked out of it.

I think the concern was, if the boards were printable, multiple consoles could be built to get around this. Probably not a major concern for one or two, but if with no limits on number of board printed, it could become a problem if enough people worked together to grief.

I've got a half-baked idea on a way to allow boards to be printed but also address this potential problem, I imagine it might take some careful consideration before passing review though.

@chromiumboy
Copy link
Contributor

chromiumboy commented Jan 6, 2025

Wait a minute, isnt there already a precaution to reduce the load on the server caused by the power monitoring console, since only one person at a time is allowed to use one? Last time I was playing engineering, if someone was using the console, everybody else was locked out of it.

I think the concern was, if the boards were printable, multiple consoles could be built to get around this. Probably not a major concern for one or two, but if with no limits on number of board printed, it could become a problem if enough people worked together to grief.

Yup, pretty much this. I need to revisit the code someday and see if I can improve its performance further

@SpaceRox1244
Copy link
Contributor

Wait a minute, isnt there already a precaution to reduce the load on the server caused by the power monitoring console, since only one person at a time is allowed to use one? Last time I was playing engineering, if someone was using the console, everybody else was locked out of it.

I think the concern was, if the boards were printable, multiple consoles could be built to get around this. Probably not a major concern for one or two, but if with no limits on number of board printed, it could become a problem if enough people worked together to grief.

I've got a half-baked idea on a way to allow boards to be printed but also address this potential problem, I imagine it might take some careful consideration before passing review though.

You mean if a significant portion of active players decided to all do that at the same time and nobody did anything about them, players or admins? Are these edge cases really that worth it? :?

@SpaceRox1244
Copy link
Contributor

Don't people get really frustrated when design decisions are made to mitigate edge case griefing but cause the majority to have less mechanics to play with? Don't motivations like that, which could be difficult on a technical level to understand as a player, create more misunderstanding and distrust between dev and community, thus pushing some to hostile action, especially considering community spaces made to stew hostility about this precautionary philosophy? I kinda think the better road here is just unclenching about it. I know it sounds like conceding, but you dont know the people youre anticipating in your head and they dont know you. Either only knows what theyre told the other thinks of them. We cant feasibly police everything.

@Aisu9

This comment was marked as abuse.

@Alpaccalypse
Copy link
Contributor Author

I'd like to see an in-game way to solve the problem, in future, though let's keep things in perspective; this only came up because I wanted to color the boards in question, and I am literally the only person I've heard of even trying to legitimately build a new atmos monitor. I was actually hoping to add atmos boards to printing, not remove power ones.

If I'm honest, I wouldn't have mentioned it if I'd known the boards would get removed, but I wouldn't categorise it as greifing-proof no matter the cost, considering how few people are even going to know this change even happened without reading the changelog.

@space-wizards space-wizards locked as off-topic and limited conversation to collaborators Jan 6, 2025
@PJB3005
Copy link
Member

PJB3005 commented Jan 6, 2025

get use to it, the end goal of wizden is to be griefing-proof no matter the cost

@Aisu9 This is a formal warning that this behavior will not be tolerated on our repo. You will be banned from the repo if you post disrespectful comments like this again.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A: Art Area: Art with no implications for other areas. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. size/S Denotes a PR that changes 10-99 lines. T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants