Fix gas pipe leaking when unanchoring or breaking them #33774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
S: Needs Review
Partmedia
reviewed
Dec 8, 2024
Content.Server/Atmos/Piping/EntitySystems/AtmosUnsafeUnanchorSystem.cs
Outdated
Show resolved
Hide resolved
beck-thompson
added
T: Bugfix
Partmedia
approved these changes
Dec 8, 2024
|
I reverted the pressure warning popup change as discussed above. |
slarticodefast
removed
the
S: Needs Review
Doctor-Cpu
pushed a commit
to Doctor-Cpu/space-station-14
that referenced
this pull request
Jan 24, 2025
…#33774) * fix gas pipe unanchoring * remove unneeded update * revert popup change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Currently when unanchoring a pipe some of the gas will leak from it, but not all of it. This means you can pick it up as a small 200L tank in your backpack and release the gas into the atmosphere by anchoring and unachoring it a second time, which can be potentially abused.$V_{pipe} / V_{total}$ which was suggested by @Partmedia in #29574.
This PR solves this by making the leak amount equal to
The removed pipe will then always be completely empty.
Why / Balance
Fixes #32632
Technical details
I simplified the way the leak amount is calculated, removing the pressure dependency and making it only volume dependend, which makes more sense. The warning popup will now show up when the pipes pressure is above standard atmospheric pressure, below that the gas still leaks, but the amount is insignificant.
When the pipe is unanchored, the node group update will be scheduled for the next tick. However, this will mean we cannot yet remove the gas from the pipe element since it is still connected with its neighbors. We cannot do this in the next tick either, because the information about the pipe entity and its node is lost by then. To solve this we force a manual update for the scheduled node groups. This should be fine performance-wise since it only happens once when a player unanchors it and the update won't be repeated in the next tick.
Media
pipe.leak.mp4
Requirements
Breaking changes
none
Changelog
🆑