-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Four new food crates for the ATS #33286
Open
AgentSmithRadio
wants to merge
15
commits into
space-wizards:master
Choose a base branch
from
AgentSmithRadio:FoodCrates
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+203
−2
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
9643f35
6 new food crates added and tested!
AgentSmithRadio aa14ed9
Removed Pistachios from BountyFruit.
AgentSmithRadio 2f6d573
Fixed typo in sweetie's pistachios description.
AgentSmithRadio 4270553
Added Pistachios tag to Sweetie's Pistachios to deal with fruit bount…
AgentSmithRadio ba93a08
Fixed a typo in snacks.yml changes.
AgentSmithRadio d87e69b
Added pistachios tag to tags.yml
AgentSmithRadio b733875
Removed Black Market Meats crate.
AgentSmithRadio 489e577
Fixed "Getmore" capitalization in Getmore Bakemore description.
AgentSmithRadio e5f0036
Removed Moth Pizza Delivery
AgentSmithRadio ea2935e
Code rewrite and testing.
AgentSmithRadio c15afe5
Typo fixes, investigating CrateFoodHappyHonkMeals entity not being re…
AgentSmithRadio 68de80e
ID name test.
AgentSmithRadio 077a518
Rewrote food.yml.
AgentSmithRadio 68dc6bd
Capitalized Sweetie's Pistachios
AgentSmithRadio dddc7f2
Getmore price raised to 750 to match.
AgentSmithRadio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -561,6 +561,7 @@ | |
| - Cake | ||
| - Pie | ||
| - Bread | ||
| - Pistachios | ||
|
|
||
| - type: cargoBounty | ||
| id: BountyVegetable | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -978,6 +978,9 @@ | |
| - type: Tag | ||
| id: Pipe | ||
|
|
||
| - type: Tag | ||
| id: Pistachios | ||
|
|
||
| - type: Tag | ||
| id: Pizza | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a VERY powerful crate. Could you tune it down a small bit? I'd cut each snack to 3 each and reduce everything else by one at least.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been meaning to restructure this PR, it's been needing a rework and I've let it fall by the wayside.
First, I want to give you the two most apt comparisons. The first is a Getmore Restock, which currently restocks 3 of each of the following in any snack.yml machine, 6 if you use both boxes on the same machine:
Effectively this crate as it is is a focused version of that restock box (which comes in 2 per crate, which costs 600), going for the same total (minus the contraband), just in the actual baking ingredients. It is then merged with the "optimal" baking crate which is Kitchen Supplies, which comes with the following:
Same concept, but a cut inventory, being less "generally" good, and being hyper-focused on baking. And yes, the Kitchen Supplies crate is in fact that good, and I think it's that way because they're an absolute pain to get from cargo, especially if you want more than one, they'd rather just give you ChefVends due to their ease of delivery.
With 3 of each snack, we're getting ~300 in value from the snacks, with a cut kitchen supplies inventory, and then you're wondering why you're ever ordering this. 3 of a reagent to cook with kind of sucks. For instance, with one such crate you can make:
Pistachios: 3 Baklava (only recipe, has the advantage of being a pie for the sake of clown/bounty)
4no Rasins: 3 Raisin Cookies (only recipe, unless you count Cak, which this crate does not cover)
Chocolate: This gets even more sad:
In order for this crate to be worth getting, I think you need to go heavy on the candy. It's a pantry crate for when Botany is refusing to grow crops for you because they have other focuses (a common issue on servers like Salamander), allowing you to still cook foods that require effort and "uncommon" ingredients through working with cargo, and without having to raid all of the snack machines on the station.
If we're going to nerf the ingredients, the worst I'd like to see is 4 on the 3 candies, or cutting pistachios and raisins and boosting the chocolate. If this crate is to exist, it has to have a reason to be taken over Kitchen Supplies and ChefVend, otherwise it'll just be bloat in the Cargo menu that will be ignored.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I trust your judgement I didn't realize how powerful the other crates where. Maybe just slightly reduce some of the candy then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm stuck in the office today, but thinking about what changes to make.
I can see cutting pistachios and raisins to 4 to still see inherent value in ordering this crate over Kitchen Supplies. If forced to cut more, it'd be to get pistachios down to 2-3, given how much relative food Baklava gives as a pie item, but I don't see what real abuse can come from having it at 4. It makes for an easy pie for clown to throw, it's another efficient way to do the pie bounty (ChefVend just does it with meat pie instead), but it doesn't break anything or shake up the meta at all beyond allowing easier no-Botany Chef play.
That said, I'm thinking about the FoodBoxCloth that's now been added to Kitchen Supplies. I think that I need to add it to this crate. Not just for moth inclusiveness and the inherent baking theme to the crate, but because I can see in 6 months time if I don't add it, a new contributor is going to see it missing from this crate and think that it's an omission and PR to get one added to it. I may as well jump ahead and add one.