Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dna from skeletons #33207

Closed
wants to merge 1 commit into from
Closed

remove dna from skeletons #33207

wants to merge 1 commit into from

Conversation

pheenty
Copy link
Contributor

@pheenty pheenty commented Nov 7, 2024

About the PR

moved dna component from basemobspecies to basemobspeciesorganic, effectively removing it from skeletons

Why / Balance

why do skeletons even have dna? especially when they have no fingerprints
well, because it was left over in #30530

Technical details

no

Media

no

Requirements

Breaking changes

i believe none
Changelog
no

@pheenty pheenty requested a review from DrSmugleaf as a code owner November 7, 2024 09:05
@github-actions github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted Changes: No C# Changes: Requires no C# knowledge to review or fix this item. and removed S: Needs Review Status: Requires additional reviews before being fully accepted labels Nov 7, 2024
@slarticodefast
Copy link
Member

Don't bones technically have DNA?

@pheenty
Copy link
Contributor Author

pheenty commented Nov 7, 2024

Don't bones technically have DNA?

Well, bones do, but in the game the only time a skeleton can leave it's dna is when stabbing itself with an implanter between the ribs (which it shouldn't be able to do in the first place). And when (or, rather, if) ipcs or other inorganic species gets added, they will definetely not have any dna in them

@pheenty pheenty changed the title move dna to basemobspeciesorganic remove dna from skeletons Nov 7, 2024
@slarticodefast slarticodefast added the S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure. label Nov 12, 2024
@SlamBamActionman SlamBamActionman added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Nov 14, 2024
@ScarKy0 ScarKy0 added T: Bugfix Type: Bugs and/or bugfixes P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. D3: Low Difficulty: Some codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted A: General Interactions Area: General in-game interactions that don't relate to another area. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 17, 2024
@slarticodefast
Copy link
Member

Hey, sorry for the wait, the discussion thread for this kinda got lost among all the others.
We had a poll among the maintainers and decided no to merge this for the following reasons:

  • Skeletons are already really powerful and removing dna from them would be another huge buff by making their crimes unable to be tracked down by the detective. Esepcially if they become sleeper agents and use implants.
  • From a realism standpoint, bones do have dna. The traces could maybe be renamed to something like "bony residue" or similar so that they are more unique.

Thank you for your contribution.

@pheenty pheenty deleted the dna branch February 14, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: General Interactions Area: General in-game interactions that don't relate to another area. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. D3: Low Difficulty: Some codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Needs Review Status: Requires additional reviews before being fully accepted S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure. T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants