Fix DoDrop to DropNextTo in container cases #30911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DoDrop is too heavy to calculation. In any other case we should use alternatives, for example DropNextTo helper method
formlessnameless
pushed a commit
to formlessnameless/imp-station-14
that referenced
this pull request
Aug 14, 2024
* Fix DoDrop to DropNextTo in container cases DoDrop is too heavy to calculation. In any other case we should use alternatives, for example DropNextTo helper method * codestyle change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Fix issue #30261 that's points to PR #30223 .
DoDropheavy to calculate (hands positions, mouse positions, moving, raises moveevents and so on).Implemented that if player's in container then
DropNextToused, that's much faster and without redundunt actions.As much as possible, we should avoid using
DoDrop.Technical details
Uses
DropNextTofor drop logic if action's have been in container.Media
Requirements
Breaking changes
Changelog
no cl, just sped