Tune spacing speed to fix under-pressure lockout

[Partmedia]

About the PR

Slightly increase spacing speed to fix under pressure lockout.

Why / Balance

Since super-slow spacing was added, under-pressure lockout has been broken.

This means that even if one small room is spaced, the vents leak all of the air out of distro and even if atmos techs repair the breach spacing will be difficult to recover from because all of distro is gone. This causes the whole station to slowly suffocate to death.

Speeding up spacing is part of the atmos roadmap.

According to @AJCM-git atmos fixes are acceptable during the freeze.

Media

Under-pressure lockout works again:

Here's a video of the adjusted spacing speed:

out-2024-05-28_21.57.21.mp4

• I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
🆑 notafet

• tweak: Slightly increase spacing speed to fix under-pressure lockout.
• fix: Fix vent under-pressure lockout.

[MjrLandWhale]

So fun question with this. What is the expected way for Atmos to repressurize an area once a vent goes into lockout? Without a way to override the lockout, the moment a room goes below 60kpa its dead in to water unless gas is brought in from a non-distro source. (Yes I am actively fighting this problem mid-round while writing this)

[deltanedas]

you have to spam wrench the vent OR replace it with an injector temporarily

[Partmedia]

Or:

• You open a door to an adjacent room with air
• You bring a canister of gas to re-pressurize above 60 kPa

[deltanedas]

You open a door to an adjacent room with air

if you do this you bring firelocks up to half the station and everyone will cry on radio that atmos is evil
and this wont work if the rooms are evenly sized, because then both rooms would be 50kpa

You bring a canister of gas to re-pressurize above 60 kPa

wasting 5 minutes walking back and forth, and you REALLY overestimate how much air 1000L is (less than a single tile)

specifically a 4.5mpa 20C air can has 1846.24 mols of air will only get a 6x6 room to exactly 50kpa

[MjrLandWhale]

Or:

• You open a door to an adjacent room with air
• You bring a canister of gas to re-pressurize above 60 kPa

1st option risks putting both rooms into lockout since you don't know the pressure nor overall volume of that room on the other side. 2nd option, although it can work, will only be consistent for a spaced area under a total of ~30tiles.

I mean, I won't disagree that these are technically options to resolve the problem. But are they good options that are communicated to players? Even the guidebook's current spacing entry can be summarized as "close the hole and the vents will begin to repressurize the room".

[MjrLandWhale]

wasting 5 minutes walking back and forth, and you REALLY overestimate how much air 1000L is (less than a single tile)

It's equivalent to a fire bucket brigade.

A different idea: Have a 'pressure lockout' override variable on the gas vent component. If you set an air alarm to fill it sets that flag to true. Then have the code skip checking for lockout pressure when true. That lets you keep the lockout higher, while also giving atmos a consistent way of mitigating spacings when they determine a room is ready to be repressurized. Thoughts?

[deltanedas]

yeah thatd be good and give a non-griefing use for fill mode

[Partmedia]

I think @MjrLandWhale 's proposal is a workable solution. I look forward to see a prototype and see how well it works.

[MjrLandWhale]

I think @MjrLandWhale 's proposal is a workable solution. I look forward to see a prototype and see how well it works.

Actually way easier than I thought. It just isn't going to be visible on the air alarm UI. In theory it should eventually be added to the air alarm UI and guidebook for clarity, but that's not something I can do at the moment.