Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

senior security jumpskirt resprite and security jumpskirt sprite minor fix #27804

Merged
merged 1 commit into from
May 9, 2024

Conversation

Dutch-VanDerLinde
Copy link
Contributor

@Dutch-VanDerLinde Dutch-VanDerLinde commented May 8, 2024

Why / Balance

old senior jumpskirt had the old security jumpskirt style as it was not respirted in #25269

also changes a few things on the normal security jumpskirt, it had an extra armband where it shouldn't have and the skirt part was too far forward

the skirt on the old sprite (the skirt part is too far):
image

new sprite skirt:
image

Technical details

Media

image
image
image
image

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

@github-actions github-actions bot added Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. labels May 8, 2024
Copy link
Contributor

github-actions bot commented May 8, 2024

RSI Diff Bot; head commit 431d5b9 merging into 130ab51
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Clothing/Uniforms/Jumpskirt/security.rsi

State Old New Status
equipped-INNERCLOTHING Modified

Resources/Textures/Clothing/Uniforms/Jumpskirt/senior_officer.rsi

State Old New Status
equipped-INNERCLOTHING Modified
icon Modified

@InfinityPandaRed
Copy link

YES SIR

Copy link
Contributor

@Flareguy Flareguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot the sleeve asymmetry on the new sec jumpskirt sprite. This looks fine otherwise, though.

Copy link
Contributor

@Flareguy Flareguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretend the above review was requesting changes. I forgot to set it to that oops

@Dutch-VanDerLinde
Copy link
Contributor Author

You forgot the sleeve asymmetry on the new sec jumpskirt sprite. This looks fine otherwise, though.

wdym, i don't see anything wrong with it
the part above the skirt looks exactly the same as the sec jumpsuit

@Flareguy
Copy link
Contributor

Flareguy commented May 9, 2024

You forgot the sleeve asymmetry on the new sec jumpskirt sprite. This looks fine otherwise, though.

wdym, i don't see anything wrong with it the part above the skirt looks exactly the same as the sec jumpsuit

The armband is supposed to be asymetrical (only appearing on one arm,) yet it appears on both east and west rotations.

@Dutch-VanDerLinde
Copy link
Contributor Author

You forgot the sleeve asymmetry on the new sec jumpskirt sprite. This looks fine otherwise, though.

wdym, i don't see anything wrong with it the part above the skirt looks exactly the same as the sec jumpsuit

The armband is supposed to be asymetrical (only appearing on one arm,) yet it appears on both east and west rotations.

image

i fixed that already i think

@Flareguy Flareguy merged commit 74e39fb into space-wizards:master May 9, 2024
13 checks passed
@Dutch-VanDerLinde Dutch-VanDerLinde deleted the senior-fix branch May 9, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants