Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plutonium core steal objective #26786

Merged
merged 12 commits into from
Jun 29, 2024
Merged

Conversation

deltanedas
Copy link
Contributor

About the PR

added plutonium core steal objective for tators and everything it needs
if you have the objective you can get a susbox containing the gear for free in the new Objectives tab of the uplink

you can deconstruct, and reconstruct, nukes to and from a disarmed state

once you get the plutonium core you can put it into a nuke core container and close it, then it cannot be opened again (unless you emag it, the intention being if theres traitors and nukies at the same time its still somewhat possible for nukies to get the core out and rebuild the nuke. can also go the other way around of a traitor yoinking the nukies' core)

depends on #26779

Why / Balance

less boring steal objectives that are just yoink/fishbomb someone for their gear, and more like mission impossible

Technical details

  • new ObjectiveUnlockCondition and StoreUnlocker pair added that let a listing only be accessible to someone that has an objective unlocking it
  • added SealableCabinet that prevents opening the nuke core container when sealed

Media

nuke.mp4
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

no

Changelog
🆑

  • add: Traitors can now be assigned to deconstruct the station's nuke for its precious plutonium core.
  • add: Added the Objectives category in the uplink with a Core Extraction Toolbox for deconstructing said nuke.

@github-actions github-actions bot added the Changes: Sprites Changes: Might require knowledge of spriting or visual design. label Apr 6, 2024
Copy link
Contributor

github-actions bot commented Apr 6, 2024

RSI Diff Bot; head commit 6fb4fd9 merging into 7994175
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Misc/nuke_core_container.rsi

State Old New Status
closed Added
core_closed Added
core_open Added
inhand-left Added
inhand-right Added
open Added

Resources/Textures/Objects/Misc/plutonium_core.rsi

State Old New Status
icon Added

Edit: diff updated after 6fb4fd9

@HoidC
Copy link
Contributor

HoidC commented Apr 7, 2024

demon core

@VektorZ1
Copy link

VektorZ1 commented Apr 8, 2024

based

@Blackern5000
Copy link
Contributor

core should probably be super radioactive, that's what the lead-lined box is for after all.

@deltanedas
Copy link
Contributor Author

it is.

@Blackern5000
Copy link
Contributor

Blackern5000 commented Apr 10, 2024

it is.

I didn't hear any rad sounds in the video, is it just not deadly enough to trigger?

@deltanedas
Copy link
Contributor Author

i didnt have a geiger counter which makes the sound, it does 4 rads/s

@Blackern5000
Copy link
Contributor

i didnt have a geiger counter which makes the sound, it does 4 rads/s

The sound still happens without a geiger counter if there's enough rads (unless that was a bug)

@deltanedas
Copy link
Contributor Author

that was never a thing

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Apr 27, 2024
@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Apr 28, 2024
@Emisse
Copy link
Contributor

Emisse commented May 10, 2024

Closed due to feature freeze May 10th-June 14th. Comment to have it reopen after this.

@Emisse Emisse closed this May 10, 2024
@deltanedas
Copy link
Contributor Author

open

@AJCM-git AJCM-git reopened this Jun 14, 2024
@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jun 14, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jun 14, 2024
@deltanedas deltanedas marked this pull request as ready for review June 14, 2024 00:38
@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Jun 20, 2024
@metalgearsloth metalgearsloth merged commit f6ce072 into space-wizards:master Jun 29, 2024
14 checks passed
@deltanedas deltanedas deleted the nuke-ops branch June 29, 2024 04:21
PJB3005 added a commit that referenced this pull request Jun 29, 2024
metalgearsloth pushed a commit that referenced this pull request Jun 29, 2024
Revert "plutonium core steal objective (#26786)"

This reverts commit f6ce072.
@Moomoobeef
Copy link
Contributor

there was literally an 11 hour window where this was merged. love it or hate it, that's pretty funny.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprites Changes: Might require knowledge of spriting or visual design. S: Needs Review Status: Requires additional reviews before being fully accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants