Emergency light update #26735
Closed
Emergency light update #26735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n is pressed on the communications terminal.
…e" button is pressed on the communications terminal." This reverts commit c730d64.
…ce" button is pressed on the communications terminal." This reverts commit 3c2d66a.
…vel, and the rotating point light turns on for alerts other than green in their respective colors. -Fixed broadcast button not being enabled
sounds good for yellow/blue/etc alert dunno about green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Modified Emergency Lights so they properly change color depending on alert level. Fixed Broadcast button due to a mistake from my previously merged #26492 PR(I made a last minute change and didn't test before pushing, and the broadcast button has been borked ever since. I will give myself 50 lashings for committing this programmer cardinal sin).
Why / Balance
The non-admin alerts did not all properly change emergency light sprite colors. Now the emergency lights start green, and change sprite color every time alert level turns on. The rotating double-cone point light now activates on all alerts except green, making alert levels have a enhanced atmospheric visual effect across the station.
Technical details
Added EmergencyLightColor to Green, blue, and red. Changed the color used for green from "Green" to "LawnGreen".
Media
Breaking changes
This causes the rotating red emergency light that comes on when power goes off to be whatever color the current alert level is on. This is unintended and only meant to change the color of its "powered" state. Working on a workaround.
Changelog
🆑