Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add health icons to the secmed hud #26725

Closed
wants to merge 8 commits into from

Conversation

PrPleGoo
Copy link
Contributor

@PrPleGoo PrPleGoo commented Apr 4, 2024

About the PR

Added health icons to the sec hud

Why / Balance

https://discord.com/channels/310555209753690112/1221690653990326273/1221690653990326273

Technical details

Media

image

  • I have added screenshots/videos to this PR showcasing its changes ingame

Breaking changes

Nope

Changelog
🆑

  • tweak: The crafted medsec hud now displays health icons too.
  • tweak: The health status icon now goes on the left for all types of med HUD.

@github-actions github-actions bot added the Changes: No C# Changes: Requires no C# knowledge to review or fix this item. label Apr 4, 2024
@Golinth
Copy link
Contributor

Golinth commented Apr 4, 2024

IMO you should keep the health icons off the HUD. It adds even more clutter to the right side of the character (3 icons at once!), and makes an already very powergamey item even more powerful.
I viewed the medsec as the sechud icon replacing the medical icon, instead of both working together.

@PrPleGoo
Copy link
Contributor Author

PrPleGoo commented Apr 4, 2024

IMO you should keep the health icons off the HUD. It adds even more clutter to the right side of the character (3 icons at once!), and makes an already very powergamey item even more powerful. I viewed the medsec as the sechud icon replacing the medical icon, instead of both working together.

I could just move the security status icons to the left. It makes more sense to have the HUD that displays 2 icons to use both sides of the mobs instead of just the right side.

@Golinth
Copy link
Contributor

Golinth commented Apr 4, 2024

I could just move the security status icons to the left. It makes more sense to have the HUD that displays 2 icons to use both sides of the mobs instead of just the right side.

Maybe the med icon on the left instead? The sec icons being on the right is ingrained in my brain from hundreds of hours in sec

@PrPleGoo
Copy link
Contributor Author

PrPleGoo commented Apr 4, 2024

I could just move the security status icons to the left. It makes more sense to have the HUD that displays 2 icons to use both sides of the mobs instead of just the right side.

Maybe the med icon on the left instead? The sec icons being on the right is ingrained in my brain from hundreds of hours in sec

There's probably med players who will yell the same thing about the medical icon. And I just moved the status - not the job.

@Golinth
Copy link
Contributor

Golinth commented Apr 4, 2024

There's probably med players who will yell the same thing about the medical icon. And I just moved the status - not the job.

Completely fair. Though it is worth noting that the sec status icons are intended to be connected to the job icons, from #26203

@PrPleGoo
Copy link
Contributor Author

PrPleGoo commented Apr 4, 2024

Ah is that what the offset is for on those things, right that makes sense. I'll just move the med icon then 👍

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Apr 4, 2024
Copy link
Contributor

github-actions bot commented Apr 4, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Apr 5, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Apr 19, 2024
@github-actions github-actions bot added S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted and removed S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted labels Apr 25, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted and removed S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted labels Apr 29, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Apr 29, 2024
@PrPleGoo
Copy link
Contributor Author

fucking kill me bro

@PrPleGoo PrPleGoo closed this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants