-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Station Anchor #26098
Station Anchor #26098
Conversation
I thought about this solution for players moving trade station to the main station but... I came up with the idea that the relative position between trade station and main station should be maintained (ideally via a soft tether). The lore explanation is that main station + trade station use the joint center mass to maintain orbit, which is why they are artificially kept an equal vector from each other. I mean this is fine as a feature and works as a stopgap solution (it's more difficult to move the main station to the trade station than the other way around) but the underlying problem remains unsolved. |
station anchor is being worked on lol |
I don't understand. Can you elaborate? What station anchor? The one in this draft? I can see that so I'm commenting on it. If you mean another one then please point me in the right direction. |
why did i think this was a comment for another pr |
The main station should also be anchored. |
We want to anchor the station. |
Got it. |
If possible, please make a shuttle anchor aswell, so that for example nukies can park their shuttle and not be afraid of it floating away. |
The sprite looks really cool, but is there reason why the anchor is separate from the gravity generator? Anchoring seems like a reasonable side effect of gravity manipulation, and it would save mappers having to include another structure (that needs to be protected with restricted access?) Also, making the grid static seems to be causing you some issues, based on your todo list. You can't just increase the mass of the grid to some ludicrously high number, or change its max velocity, rate of acceleration, or friction coefficient, to dampen movement to be effectively zero? |
probably because shuttles use gravity generators too |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Closed due to feature freeze May 10th-June 14th. Comment to have it reopen after this. |
The shuttle console and docking issues appear to be fixed. @juliangiebel let me know if there were other bugs that you encountered. Otherwise, this is ready for review. |
Resources/Prototypes/Entities/Structures/Machines/gravity_generator.yml
Outdated
Show resolved
Hide resolved
* Work on abstracting out chargeup functionality/ui from grav gen * Work on station anchor * Finish implementing station anchors * uhh yeah * ok. * fix tests * whoops * Get the last extraneous yaml fail * PJB review * beast mode... ACTIVATE! --------- Co-authored-by: Ed <[email protected]> Co-authored-by: EmoGarbage404 <[email protected]>
* Work on abstracting out chargeup functionality/ui from grav gen * Work on station anchor * Finish implementing station anchors * uhh yeah * ok. * fix tests * whoops * Get the last extraneous yaml fail * PJB review * beast mode... ACTIVATE! --------- Co-authored-by: Ed <[email protected]> Co-authored-by: EmoGarbage404 <[email protected]>
About the PR
This PR adds the station anchor. A machine that prevents grids from moving if active.
There is a version that doesn't use power and is indestructible
This PR also abstracts out the charging functionality and ui of the gravity generator into the
PowerChargeSystem
Why / Balance
Putting this on the trade station prevents players from moving the trade station
Technical details
Sets grids to static when active
Media
Breaking changes
TODO:
Setting the grid to static prevents it from showing up on the shuttle console and it prevents the arrivals shuttle from docking.
Changelog
🆑