Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Station Anchor #26098

Merged
Merged

Conversation

juliangiebel
Copy link
Contributor

@juliangiebel juliangiebel commented Mar 14, 2024

About the PR

This PR adds the station anchor. A machine that prevents grids from moving if active.
There is a version that doesn't use power and is indestructible

This PR also abstracts out the charging functionality and ui of the gravity generator into the PowerChargeSystem

Why / Balance

Putting this on the trade station prevents players from moving the trade station

Technical details

Sets grids to static when active

Media

image
image

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

TODO:

Setting the grid to static prevents it from showing up on the shuttle console and it prevents the arrivals shuttle from docking.

Changelog

🆑

  • add: Adds the station anchor. It anchors stations in space and prevents them from moving.

@github-actions github-actions bot added Changes: Sprites Changes: Might require knowledge of spriting or visual design. Changes: UI Changes: Might require knowledge of UI design or code. labels Mar 14, 2024
Copy link
Contributor

github-actions bot commented Mar 14, 2024

RSI Diff Bot; head commit c70817b merging into d4b55f5
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Structures/Machines/station_anchor.rsi

State Old New Status
station_anchor Added
station_anchor_unlit Added

Edit: diff updated after c70817b

@LordCarve
Copy link
Contributor

I thought about this solution for players moving trade station to the main station but...
They can still move the main station to the trade station. And we don't want to anchor the main station.

I came up with the idea that the relative position between trade station and main station should be maintained (ideally via a soft tether). The lore explanation is that main station + trade station use the joint center mass to maintain orbit, which is why they are artificially kept an equal vector from each other.

I mean this is fine as a feature and works as a stopgap solution (it's more difficult to move the main station to the trade station than the other way around) but the underlying problem remains unsolved.

@UbaserB
Copy link
Member

UbaserB commented Mar 14, 2024

I thought about this solution for players moving trade station to the main station but... They can still move the main station to the trade station. And we don't want to anchor the main station.

I came up with the idea that the relative position between trade station and main station should be maintained (ideally via a soft tether). The lore explanation is that main station + trade station use the joint center mass to maintain orbit, which is why they are artificially kept an equal vector from each other.

I mean this is fine as a feature and works as a stopgap solution (it's more difficult to move the main station to the trade station than the other way around) but the underlying problem remains unsolved.

station anchor is being worked on lol

@LordCarve
Copy link
Contributor

station anchor is being worked on

I don't understand. Can you elaborate? What station anchor? The one in this draft? I can see that so I'm commenting on it. If you mean another one then please point me in the right direction.

@UbaserB
Copy link
Member

UbaserB commented Mar 14, 2024

station anchor is being worked on

I don't understand. Can you elaborate? What station anchor? The one in this draft? I can see that so I'm commenting on it. If you mean another one then please point me in the right direction.

why did i think this was a comment for another pr

@juliangiebel
Copy link
Contributor Author

The main station should also be anchored.
Also please move discussions about this to discord or github discussions

@metalgearsloth
Copy link
Contributor

I thought about this solution for players moving trade station to the main station but...
They can still move the main station to the trade station. And we don't want to anchor the main station.

We want to anchor the station.

@LordCarve
Copy link
Contributor

We want to anchor the station.

Got it.
I don't think this is an ideal decision, but it also outright solves a lot of problems and complexities so it's probably the smart decision. I'm perfectly fine with it. I was just under the impression that we didn't want to anchor the main station.
Thanks for clarifying!

@Vaaankas
Copy link
Contributor

If possible, please make a shuttle anchor aswell, so that for example nukies can park their shuttle and not be afraid of it floating away.

@chromiumboy
Copy link
Contributor

The sprite looks really cool, but is there reason why the anchor is separate from the gravity generator? Anchoring seems like a reasonable side effect of gravity manipulation, and it would save mappers having to include another structure (that needs to be protected with restricted access?)

Also, making the grid static seems to be causing you some issues, based on your todo list. You can't just increase the mass of the grid to some ludicrously high number, or change its max velocity, rate of acceleration, or friction coefficient, to dampen movement to be effectively zero?

@Dutch-VanDerLinde
Copy link
Contributor

The sprite looks really cool, but is there reason why the anchor is separate from the gravity generator? Anchoring seems like a reasonable side effect of gravity manipulation, and it would save mappers having to include another structure (that needs to be protected with restricted access?)

Also, making the grid static seems to be causing you some issues, based on your todo list. You can't just increase the mass of the grid to some ludicrously high number, or change its max velocity, rate of acceleration, or friction coefficient, to dampen movement to be effectively zero?

probably because shuttles use gravity generators too

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Mar 30, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Apr 18, 2024
@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Apr 26, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Emisse
Copy link
Contributor

Emisse commented May 10, 2024

Closed due to feature freeze May 10th-June 14th. Comment to have it reopen after this.

@EmoGarbage404
Copy link
Contributor

8373905e82c8bf5c0a093f984bf135e5

@EmoGarbage404 EmoGarbage404 reopened this Aug 21, 2024
@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Aug 21, 2024
@EmoGarbage404
Copy link
Contributor

The shuttle console and docking issues appear to be fixed. @juliangiebel let me know if there were other bugs that you encountered. Otherwise, this is ready for review.

@EmoGarbage404 EmoGarbage404 marked this pull request as ready for review August 21, 2024 04:07
@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Aug 21, 2024
@EmoGarbage404 EmoGarbage404 requested a review from PJB3005 August 29, 2024 18:25
@PJB3005
Copy link
Member

PJB3005 commented Aug 29, 2024

Test failure is legit
image

@EmoGarbage404 EmoGarbage404 merged commit 417d3a8 into space-wizards:master Aug 31, 2024
13 checks passed
Erisfiregamer1 pushed a commit to The-Arcadis-Team/arc-station-14 that referenced this pull request Jan 9, 2025
* Work on abstracting out chargeup functionality/ui from grav gen

* Work on station anchor

* Finish implementing station anchors

* uhh yeah

* ok.

* fix tests

* whoops

* Get the last extraneous yaml fail

* PJB review

* beast mode... ACTIVATE!

---------

Co-authored-by: Ed <[email protected]>
Co-authored-by: EmoGarbage404 <[email protected]>
Erisfiregamer1 pushed a commit to The-Arcadis-Team/arc-station-14 that referenced this pull request Jan 9, 2025
* Work on abstracting out chargeup functionality/ui from grav gen

* Work on station anchor

* Finish implementing station anchors

* uhh yeah

* ok.

* fix tests

* whoops

* Get the last extraneous yaml fail

* PJB review

* beast mode... ACTIVATE!

---------

Co-authored-by: Ed <[email protected]>
Co-authored-by: EmoGarbage404 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprites Changes: Might require knowledge of spriting or visual design. Changes: UI Changes: Might require knowledge of UI design or code. S: Needs Review Status: Requires additional reviews before being fully accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.