Made Sec Hud Show Borg Job Icons + Made Borgs Unimplantable #26004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…but not a syndicate) and if so to add the borg job icon to the result. Updated BorgChassisComponent.cs to include a new field called "BorgJobIcon" that holds the borg's job icon. Updated base_borg_chassis.yml to include the Unimplantable tag.
1 task
1 task
|
@Zadeon PR doesn't work so are you coming back to fix this. |
metalgearsloth
added
the
S: Derelict
github-actions
bot
added
the
S: Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
I probably won't be able to work on this at the moment, sorry. |
|
reopen if you're able to come back to this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
This PR makes it so that people wearing sec huds will see the borg job icon beside borgs instead of the unknown job icon. This only works with station borgs and not syndicate borgs. Syndicate borgs will show up as unknown to people wearing sec huds. Also I found through testing that borgs didn't have the Unimplantable tag, so this PR also fixes that.
Closes #25211
(I had to remake this PR because I broke the original branch when merging).
Why / Balance
It felt strange that we had the borg job icon available but borgs would always show up as unknown when using the sec hud so I wanted to fix that. Unfortunately, this change clashes with the current ruling for borgs where if somebody has a job icon displayed then it means they're a crew member. This change makes borgs also see borg job icons for other borgs (because they use the same system sec huds use for showing job icons). I'm making this PR now in the state it's currently in because I could not for the life of me figure out how to code it so that if you are playing as a borg you do not see job icons over other borgs. Also couldn't figure out how to make syndicate borgs show the borg job icon if you're playing as a nuke op. I'm willing to implement this functionality if somebody can show me how (or leave the PR as is and we redefine borg rules, whichever is easier).
Technical details
In ShowSecurityIconsSystem.cs inside the DecideSecurityIcon function, it will now check if the entity has the BorgChassisComponent and does not have the ShowSyndicateIconsComponent. If true, it will grab a new BorgJobIcon field added to BorgChassisComponent which holds the JobIconBorg status and set jobIconToGet to this value.
Added Unimplantable to the tags of BaseBorgChassis.
Media
PoV of a crew member wearing sec hud:
PoV of a station borg:
PoV of a nuclear operative:
Breaking changes
None.
Changelog
🆑