make thief a subgamemode #25740
Merged
make thief a subgamemode #25740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 1, 2024 01:37
github-actions
bot
added
the
S: Needs Review
|
|
metalgearsloth
approved these changes
Mar 1, 2024
|
At some point this just needs to be dynamic but better than whatever got merged before. |
|
Does this stop thieves from spawning on nukie rounds? |
|
no its just refactor
|
|
nvm i just didnt opt in to thief |
EmoGarbage404
requested changes
Mar 2, 2024
EmoGarbage404
added
the
S: Awaiting Changes
github-actions
bot
removed
the
S: Awaiting Changes
| @@ -93,6 +93,7 @@ | |||
| showInVote: false | |||
| rules: | |||
| - Traitor | |||
| - SubGamemodes | |||
There was a problem hiding this comment.
Suggested change
| - SubGamemodes | |
| - SubGamemodesRule |
troll
There was a problem hiding this comment.
phone webedit ops to the rescue
EmoGarbage404
approved these changes
Mar 2, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
thing ripped out of turf war so it can be merged now
Why / Balance
adding rule components for 1 gamemode onto another gamemode is evil
Technical details
see other pr
Media
the smite still works
adding game rule is real
roundstart random thief rule works, on traitor preset
Breaking changes
ruleChanceremoved fromThiefRule, which is no longer added to random gamemodes' rules. use theSubGamemodescomponent instead.Changelog
no cl no fun