Make examine use tooltips. #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
rbertoche
pushed a commit
to rbertoche/space-station-14
that referenced
this pull request
Oct 1, 2022
* Nuclear Operative Medic (space-wizards#8274) * Update belts.yml * Add files via upload * Update hypospray.yml * Update hypospray.yml * Update belt.yml * Update belts.yml * Add files via upload * Update misc_startinggear.yml * Update belts.yml * Update misc_startinggear.yml * Update misc_startinggear.yml * Update belt.yml * Update duffelbag.yml * Update duffelbag.yml * Update misc_startinggear.yml * Update belts.yml * Update chemistry-bottles.yml * Update chemistry-bottles.yml * Update belt.yml * Update belt.yml * Unrestrict device net ids (space-wizards#8332) * map update (space-wizards#8355) * Automatic changelog update * Saltern Update 3.4 (space-wizards#8346) * Moose Update 2.2 (space-wizards#8345) * Marathon Update 1.6 (space-wizards#8344) * Bagel 13.4 (space-wizards#8342) * Set the Medical Scanner to Climbable (space-wizards#8270) * Allow the Medical Scanner to be climbed to avoid stuck patients * Set medical scanner and cloning machine collision layers to allow mobs to pass through * Revert "Set medical scanner and cloning machine collision layers to allow mobs to pass through" This reverts commit e15e294. * Automatic changelog update * Make sandbox the local gamemode (space-wizards#8360) * Adds a reoccurrence delay to station events (space-wizards#8359) * Adds a reoccurence delay to station events * typo * total minutes * Update Content.Server/StationEvents/Events/StationEvent.cs * Update Content.Server/StationEvents/Events/StationEvent.cs * reset Co-authored-by: ike709 <[email protected]> * Automatic changelog update * Command Locked and Captain Locked High Sec Doors (space-wizards#8340) * Update access.yml * Update access.yml * Fix airlocks on some maps (space-wizards#8363) * Fix airlocks on some maps * Make MapsLoadableTest say the map that failed * Pirate Shuttle Update 1 (space-wizards#8347) * Add files via upload * Add files via upload * Maid outfit for janidrobe (space-wizards#8071) Co-authored-by: metalgearsloth <[email protected]> * Fix stack overflow on rigged power cell explosion. (space-wizards#8382) Remove the set to cell charge from explosion code. I assume the cell won't see much use since it's about to be deleted anyways. * Microwave was stuck in busy state on some BeingMicrowavedEvents (space-wizards#8381) * Make all animals and pets disease carriers (space-wizards#8376) * Automatic changelog update * Adds a cvar for server rules (space-wizards#8365) Co-authored-by: Veritius <[email protected]> Co-authored-by: ike709 <[email protected]> * Automatic changelog update * Fix negative block game speed values (space-wizards#8389) * Fix flashlight item status not updating on insert/eject of cell. (space-wizards#8388) * Wires patches (space-wizards#8385) * Port vomit from Nyano (space-wizards#8349) * Automatic changelog update * Fixes some high speed item issues (space-wizards#8361) * Automatic changelog update * Fix issue where empty power cells would still explode in the microwave (space-wizards#8393) * Automatic changelog update * Barratry Hotfix (space-wizards#8391) * unbork * fIXES * Markings tweaks (space-wizards#8394) * fixes issue with indexing into colors on multi-sprite markings * should rebuild the dummy upon character profile switch in client * markings, when selected, should now default to the current character's skin color * whoops, missed one * adds a type serializer into marking points * that has to be a list serializer, oops * Update submodule * Muting lobby music now mutes round-end music (space-wizards#8418) Co-authored-by: ike709 <[email protected]> * Automatic changelog update * Adds brig access to hop (space-wizards#8379) * Adds brig access to hop * removed security access in favor of brig * Automatic changelog update * Add completions for ForceMap and ForcePreset * Make adminwho require admin perms (space-wizards#8421) * Add VVAccess to SignalTransmitterComponent (space-wizards#8400) * Make asteroid rocks smooth with walls (space-wizards#8358) * Prevent dead mobs from healing in beds (space-wizards#8419) Co-authored-by: metalgearsloth <[email protected]> * Automatic changelog update * Fix cursor popups (space-wizards#8401) * Fix cursor popups * RemoveSwap * adds shot glasses to vendor (space-wizards#8411) * Inflatable wall fix (space-wizards#8409) * adds a check for canreach in SpawnAfterInteract * adds a check for the new field * Automatic changelog update * mouse crate (space-wizards#8377) * Automatic changelog update * Clarify that the repo contains non-commercial assets (space-wizards#8438) * Clarify that the repo contains non-commercial assets * Update README.md * Mime cleanup (space-wizards#8433) * Bagel Update 13.5 (space-wizards#8410) * Pillar update 090522 (space-wizards#8386) * Automatic changelog update * Give nukies a medic (space-wizards#8353) Co-authored-by: metalgearsloth <[email protected]> * Automatic changelog update * Update bucket.yml (space-wizards#8443) * Automatic changelog update * Mousetraps (space-wizards#8440) Co-authored-by: Kara <[email protected]> * Automatic changelog update * Turn off gravity on remove (space-wizards#8446) * Kill unarmed combat comp (space-wizards#8420) * New parallax, again (space-wizards#8395) * weh Multiplies the amount of power used by the battery guns, triple-ish for the laser cannon and a fuckton more for the xray * Parallax again * Automatic changelog update * Verb icon tiling (space-wizards#8457) * webedit fix moment. Fixes right click menu separation. * Update submodule * Emergency lights fixes (space-wizards#8454) * Automatic changelog update * Corrects the fact the dim layers were fixed in place due to an indentation error. (space-wizards#8461) * fix cargo fuel tank order (space-wizards#8460) * Automatic changelog update * Fix action icons (space-wizards#8436) * Automatic changelog update * Fix emitter crash on non-exact power float (space-wizards#8459) * Update submodule * Completions for the warp command (space-wizards#8470) * Give station events command completions, cleanup (space-wizards#8464) * Singulo eats unpowered containment gens (space-wizards#8343) * Add static "IsPowered" method (space-wizards#8434) * Add static "IsPowered" method * Use IsPowered in more places Co-authored-by: wrexbe <[email protected]> * Automatic changelog update * Allows people to resist out of crates (space-wizards#8471) * Automatic changelog update * OnTriggerCollide Bug fix (space-wizards#8467) * ez gg dubskis * meteor * Update meteors.yml * Automatic changelog update * Fixes the singularity bouncing off the station. (space-wizards#8452) * Fixes the singularity bouncing off the station. * Update Content.Shared/Singularity/SharedSingularitySystem.cs Co-authored-by: wrexbe <[email protected]> Co-authored-by: wrexbe <[email protected]> * Automatic changelog update * Fix inaccessible ready button in lobby (space-wizards#8465) * Fix inaccesible ready button in lobby * a * vote popups * splitz * Automatic changelog update * Mini Gravity Generator (space-wizards#8449) * meenee * Update Resources/Prototypes/Entities/Structures/Machines/gravity_generator.yml Co-authored-by: metalgearsloth <[email protected]> Co-authored-by: metalgearsloth <[email protected]> * Automatic changelog update * Nukes the arrivals shuttle thrusters on Delta. (space-wizards#8473) * Automatic changelog update * Engine UI FrameUpdate compat, Speech bubble first frame fix (space-wizards#8472) * Compat fix for engine UI FrameUpdate order change. Engine is getting FrameUpdate changed to run BEFORE style & layout. This is needed to avoid exploding. * Fix speech bubble layout on first frame. * Extended access system (space-wizards#8469) * Extended access system Allows jobs to specify "extended" access levels, which will be granted if the round-start crew count is below a certain threshold. * Extended accesses for jobs * Spook * Automatic changelog update * Atmos sign (space-wizards#8462) * Add files via upload * Update meta.json * Update meta.json * Update signs.yml * Update meta.json * Adds twenty-one new smites, moves the explosion smite to the verb category. (space-wizards#8456) * Adds seven new smites, moves the explosion smite to the verb category. * adds even more smites. * Even more smites, some messages for specific smites. * Adds even more smites. * Removes some junk, adds a smite that angers the pointing arrows. * get rid of dumb component. * Remove mistake from verb menu presentation. * How did that happen? * whoops * c * e * fuck * Loading... * removes the BoM go away * adds the funny kill sign. Fixes ghost smite. * Move systems around. * Adjust organ vomit. * Adds a smite that turns people into an instrument, and one that removes their gravity. * oops * typo Co-authored-by: Veritius <[email protected]> * Automatic changelog update * pillar minor update (space-wizards#8466) * Automatic changelog update * Spationaut Resprite (space-wizards#8458) * resprite * inhand fix * small engi fix * losing my mind aaaa fuck me * what the hell is wrong with me * Update Resources/Textures/Clothing/Head/Hardsuits/spatiohelm.rsi/meta.json Co-authored-by: wrexbe <[email protected]> * Update Resources/Textures/Clothing/OuterClothing/Hardsuits/spatio.rsi/meta.json Co-authored-by: wrexbe <[email protected]> Co-authored-by: wrexbe <[email protected]> * Automatic changelog update * Fix rules popup (space-wizards#8485) * CVar to show rules popup for localhost. For testing purposes. * Fix rules popup being broken and throwing. 😐 * Hotfix weightless riding (space-wizards#8477) * Hotfix weightless riding * a * Finally fixes file templates (space-wizards#8476) * Add entitysystem and component templates. * Adds doc comments to templates and also a prototype template. * Add an inheriting prototype template. * add inheritdocs where appropriate. * rebalance pressure, airloss, cold (space-wizards#8482) * Automatic changelog update * Play sound and request window on cloning (space-wizards#8323) ECS TBD. Fish did a pr but it was doing a lot at once. * Allow ghosts to ignore obstructions (space-wizards#8397) * Automatic changelog update * Mousetrap fixes/tweaks (space-wizards#8484) * fixes issues with mousetraps, adds activation popup * sure * me when i scroll up a bit in discord * Fix StepTrigger error (space-wizards#8480) * Fix StepTrigger error * Changed it * Update Content.Shared/StepTrigger/StepTriggerSystem.cs Co-authored-by: metalgearsloth <[email protected]> * Update Content.Shared/StepTrigger/StepTriggerSystem.cs Co-authored-by: metalgearsloth <[email protected]> * Update StepTriggerSystem.cs * Update StepTriggerSystem.cs Co-authored-by: metalgearsloth <[email protected]> * Attempt to reduce audio helper resolves (space-wizards#8493) * Bump engine to 0.19.0.0 (space-wizards#8417) * Remove IgnoreComponents on the client (space-wizards#8308) * Fix GasThermoMachine upgrading (space-wizards#8313) * Automatic changelog update * fix hardhat shading (space-wizards#8508) * step trigger fix + optimization (space-wizards#8503) * Underplating Must Die (The Movie) (The Video Game) (space-wizards#8498) * Add a BRB Sign (space-wizards#8437) * Automatic changelog update * Set alert level command (space-wizards#8507) * Add force mode for setting alert level * Add console command for changing alert level * Filename typo * Return delta disableSelection property * Make locked a component property * Not lock green level after nuke disarm * Add completions to the damage command (space-wizards#8510) * Fix map rendering (space-wizards#8514) * Fix negative grids * Map renderer: skip, and warn on empty grids. * Fix local transform * Improve the templates, add networked entity system templates. (space-wizards#8518) * Update submodule * Simple Magic Spellbook System (space-wizards#7823) Co-authored-by: metalgearsloth <[email protected]> * Automatic changelog update * Make AdminLogsSystem an IoC manager (space-wizards#8492) * Make log not entity system * Fixes * Remove extra ; * Gamma & Epsilon alerts levels (space-wizards#8517) * Add Gamma & Epsilon alert levels * Add license for epsilon sound * Remove mention about gamma armory * Add missing license sources * Delete unused sound * Automatic changelog update * Waystation: The Station That Will Succeed Packed's Legacy (space-wizards#8398) * Waystation: The Station That Will Succeed Packed's Legacy * Hopefully fixes YAML errors * Fixes missing HV wires * Security door * Addresses review * Add station component to waystation * Fix minor stuff * BecomeStation Casing Weh Co-authored-by: wrexbe <[email protected]> * Automatic changelog update * Decouples starting gear from UtilityAI (space-wizards#8512) * Interrupt uncuff on target movement (space-wizards#8511) * Fix mapping actions for engine PR (space-wizards#8296) * Adds TimedDespawn component to Invisible Walls, nukes DeleteAfterTime (space-wizards#8528) * Adds TimedDelete component to Invisible Walls * Removes Delete After Time * Dirty Command (space-wizards#8533) Dirty Command Co-authored-by: metalgearsloth <[email protected]> * Dirty command fix (space-wizards#8534) * Fix server update restarts when server paused. (space-wizards#8509) * Examinable Anchors (space-wizards#8407) * Automatic changelog update * Update Changelog.yml * More github action tests (space-wizards#7301) * Update submodule * Surveillance cameras (space-wizards#8246) * cameras but i didn't feel like git stashing them * Adds more functionality server-side for surveillance cameras * rider moment * Adds skeleton for SurveillanceCameraMonitorBoundUi on client * whoops * makes surveillance camera monitor UI more defined * removes tree from SurveillanceCameraMonitorWindow * surveillance camera active flag, other routing things * actually sets how SurveillanceCameraMonitorSystem sends camera info to clients * adds entity yaml, changes field * adds the camera/monitor entities, makes the UI open * SurveillanceCameraRouters (not implemented fully) * subnets for cameras, server-side * it works! * fixes rotation in cameras * whoops restores surveillance cameras to ignored components makes it so that switching cameras now lerps the other camera * makes the UI work * makes it so that cameras actually refresh now * cleanup * adds camera.rsi * cleans up prototypes a bit * adds camera subnet frequencies, cameras in subnets * adds surveillance camera router subnets * might fix testing errors * adds the circuit board to the surveillance camera monitor * fixes up the camera monitor (the detective will get his tv soon) * adds heartbeat, ensures subnet data is passed into cameras to send * fixes up a few things * whoops * changes to UI internals * fixes subnet selection issue * localized strings for UI * changes 'test' id to 'camera' for cameras * whoops * missing s * camera static! * adds a delay to camera switching * adjusts a few things in camera timing * adds setup for cameras/routers, localization for frequency names * adds setup ui for routers, makes subnet names in monitor window follow frequency name in prototype * localization, some cleanup * ui adjustments * adds surveillance camera visuals * fixes a bug when closing the UI for monitors * adds disconnect message to UI * adds construction graph to cameras * adds the camera to the construction menu * fixes network selection for setup, tweak to assembly * adds surveillance camera router construction, fixes up surveillance camera wire cutting * adds disconnect button to monitor UI * switches around the status text * tweaks monitor UI * makes the address actually show * might make tests pass * UI adjustments, hard name limit * ok, that didn't work * adds wireless cameras * makes the television work/look nicer * adds tripod cameras in addition to mobile cameras * makes wireless cameras constructable * fixes up those prototypes * reorganization in C#, small cleanup * ensures that power changes deactivate some devices * adds a component to the television, comments out a function * actually, never mind, i forgot that wireless cameras existed/are creatable for a second * tweaks to router construction, removes SubnetTest from prototypes * removes it from frequencies too * Apply suggestions from code review Co-authored-by: metalgearsloth <[email protected]> * type serializers into components * setup window opens centered, enum is now byte * replaces active monitor list with ActiveSurveillanceCameraMonitorComponent * adds paused/deleted entity checks, changes how verbs are given * removes EntitySystem.Get<T>() references * fixes bug related to selecting network from setup, alphabet-orders network listing in setup * rider moment * adds minwidth to surveillance camera setup window * addresses reviews * should fix the issue with camera visuals not updating properly * addresses some reviews * addresses further review * addresses reviews related to RSIs * never needed a key there anyways * changes a few things with routers to ensure that they're active * whoops * ensurecomp over addcomp * whoops Co-authored-by: metalgearsloth <[email protected]> * Automatic changelog update * Makes camera monitors/the television constructable (space-wizards#8542) * Update emergency light animation. (space-wizards#8531) * Adds health analyzer to 3 first aid kits (space-wizards#8535) * adds healthanalyzer to 3 first aid kits normal, advanced and combat kits only * increase first aid kit sizes * Automatic changelog update * Fix bug where being eaten as a mouse tethers your ghost to who ate you (space-wizards#8338) * Check if the ghost spawn position is in inventory/default/null-space * attach to grid instead of default spawn point * Simply attach to grid first before entity is deleted * Alert level reloads (space-wizards#8530) * adds prototype reload for AlertLevelSystem, reorganizes selectable alerts a bit * makes alert levels not necessarily require localization * oops * sus * does the same for announcements as well * oh, that's not how that works at all * ok, NOW it works * fixes localization, adds event for when alerts are reloaded * addresses review * Automatic changelog update * Modular landmines (space-wizards#8351) * Automatic changelog update * Gun refactor (space-wizards#8301) Co-authored-by: Kara <[email protected]> Co-authored-by: T-Stalker <[email protected]> Co-authored-by: T-Stalker <[email protected]> Co-authored-by: ElectroJr <[email protected]> Co-authored-by: metalgearsloth <[email protected]> * Update submodule * Update submodule * Saltern Update 3.5 (space-wizards#8567) * Bagel Update 13.6 (space-wizards#8563) * Marathon Update 1.7 (space-wizards#8566) * Cleanup gun containers (probably last time) (space-wizards#8575) - snake_case instead of kebab-case - Remove old MagazineBarrel containers - Remove old event * AccessReader IsAllowed use resolve (space-wizards#8527) * Re-implement hitscan sounds (space-wizards#8581) I forgor. Also added RW to ballistic prototype for funsies. * Goon floor pack 1 (space-wizards#8267) * floors boxing, arcadeblue2 and carpet clown * adds gym, metaldiamond and carpetoffice from goon * adds variants for boxing and gym * tile variants updated * Fix access system (space-wizards#8585) * Add an access system proxy(space-wizards#8586) * Gun whitelist fixies (space-wizards#8587) * Gun sound fixes (space-wizards#8592) * Automatic changelog update * Update submodule * Add files via upload (space-wizards#8591) * Adds the ability to not play admin sounds (space-wizards#8242) Co-authored-by: ike709 <[email protected]> Co-authored-by: Vera Aguilera Puerto <[email protected]> * Automatic changelog update * Fix thruster shutdown (space-wizards#8598) * Nerf SMG accuracy (space-wizards#8589) * Automatic changelog update * Fix invalid XAML markup cases Rider EAP is highlighting these now * Post Light sprite fix and state (space-wizards#8578) * adjusted post light sprite and added empty state * update construction location * Automatic changelog update * Reduces the nuke detonation time to 120 (space-wizards#8599) * weh Multiplies the amount of power used by the battery guns, triple-ish for the laser cannon and a fuckton more for the xray * Reduces nuke detonation time * comment * Update Content.Server/Nuke/NukeComponent.cs Co-authored-by: wrexbe <[email protected]> * Automatic changelog update * Fix aghost crashes (space-wizards#8556) There's still some oddity around MobObserver / AdminObserver where if you move after suicide then aghost you return to your original body, but at least you won't spawn a billion AdminObservers anymore or crash if you controlmob one. * Adds max pressure to gas miners (space-wizards#8543) * adds max pressure to gas miners 300kPA down from max (4500) * reduces the gas amount * Automatic changelog update * Hotfix revolver serialization (space-wizards#8561) * Hotfix revolver serialization * a * wakemkiaofalliance (space-wizards#8603) * Adds security cameras to Delta, also more decals. (space-wizards#8605) * Automatic changelog update * Dwarves are no longer selectable. (space-wizards#8596) * Automatic changelog update * Shotgun nerfs (space-wizards#8590) - Bojevic firerate dropped from 3 to 2 - Pellet damage from 13 to 8 (3 shotting players instead of 2 shot) - Slightly more spread in line with the design doc. Slug spread I made as accurate as an SMG (so not quite full-screen mob hits but pretty close). * Automatic changelog update * Emitter 1984 - cargo and construction (space-wizards#8606) * Automatic changelog update * Fix debug tests with engine change (space-wizards#8609) * Re-enable sandbox for <5 players (space-wizards#8610) * Automatic changelog update * Floor tile ECS (space-wizards#8577) * Add ContainerContainer to boards (space-wizards#8569) * Add ContainerContainer for powered stuff (space-wizards#8570) * Fix pipe net conservation laws (space-wizards#8540) * adds destructible to power structures (space-wizards#8536) * Automatic changelog update * Fix spray collision (space-wizards#8612) * Automatic changelog update * Prune most yml ambientsound entries (space-wizards#8573) * Remove (some?) pop-up error spam. (space-wizards#8538) * Emergency Response Team (space-wizards#6258) * Clothing pass 1 Backpacks, hardsuits and helmets pass 1 * ERT Leader Role first pass * ERT Backpacks (nearly there) * ERT Backpacks final * ERT helmets pass 1 * remaining hardsuit sprites added. * ERT leader ID * removed duplicates * hardsuits + helmets entities * ID + PDA for ERT * ERT leader role pass 1 * job icons / markers for ERT * military / ert name dataset * starting gear pass 1 for ERT * removed in favor of singular ERT roles file * ERT mobs for spawning * ERT spawn points added * fixed case on ERT name * Increased ERT access to most areas * ERT ghost role takeover fixes * ERT removed invalid parent * path issue resolved * more file path fixes * fixes random naming pt 1 * Buffs ERT hardsuits and integrates helmet parents ert to syndie hardsuit and adds toggleable helmet * Adds suit storage slot and cargo access * Adds backpack fills for ERT * Updates ERT loadout for filled backpacks + other misc changes * buff ERT backpack storage * fixes ert jani backpack fills * tweaks spawn loadout to EVA * gave centcom official AA * formatting * ERT shuttle mapped with spawners * update access * Automatic changelog update * Communications Console: The ECSining (space-wizards#8374) Co-authored-by: metalgearsloth <[email protected]> Co-authored-by: metalgearsloth <[email protected]> * Automatic changelog update * Holofan Projector Upstream from Nyano (space-wizards#8352) Co-authored-by: metalgearsloth <[email protected]> * Implements item pricing, and piracy. (space-wizards#8548) * Start implementing item pricing. * Flesh out prices a bit, add the appraisal tool. * Add prices to more things. * YARRRRRRR * gives pirates an appraisal tool in their pocket. * Makes the various traitor objectives valuable. Also nerfs the price of a living person, so it's easier to bargain for them. * Address reviews. * Address reviews. * Automatic changelog update * Fix pirates. Whoops. (space-wizards#8623) * Fix pirates. Whoops. * Remove debug logs. * Reduce the amount of drinks per robust softdrinks machine (space-wizards#8629) * Automatic changelog update * Makes ERT roles not show up on role select (space-wizards#8630) * Fixes circuit printing for generators and emitter (space-wizards#8613) * Automatic changelog update * Fix nullable error (space-wizards#8632) * Prevent inflatables from being placed on walls/doors (space-wizards#8624) * Check if tile is blocked * Move check to IsTileClear * Automatic changelog update * Don't cancel pulling a corpse because the player ghosted (space-wizards#8621) * Check if pullable is dead * Update SharedPullableSystem.cs Co-authored-by: wrexbe <[email protected]> * Automatic changelog update * Revolver fix (again) (space-wizards#8635) * Gun spread overlay (space-wizards#8588) * Fixes ID/Names for Sterile masks / latex gloves. Adds nitrile glove box (space-wizards#8607) * fixes box ID/names for mask and gloves. Adds nitrile box * map update for ID change * crate fills fix * Automatic changelog update * Change map prototype for gloves/mask * Fix shotgun spent visuals (space-wizards#8639) * Make shift laser gun (space-wizards#8125) * Added the TechFabCircuitboards and made them spawn in the head's lockers * Added the construction graph for makeshift laser * Added the construction graph to the yml of makeshiftlaser * Resolving branching issues * resolving branching issues * resolving branching issues * Small fixes * Update battery_guns.yml * Update battery_guns.yml * Update battery_guns.yml Co-authored-by: wrexbe <[email protected]> Co-authored-by: wrexbe <[email protected]> * Automatic changelog update * LMG nerf (space-wizards#8637) * Fix docking fixture crash (space-wizards#8640) * Automatic changelog update * Missing nullables (space-wizards#8634) * Refactor magvisualizer (space-wizards#8568) * Fix comms consoles not working (space-wizards#8644) Co-authored-by: metalgearsloth <[email protected]> Co-authored-by: metalgearsloth <[email protected]> * Automatic changelog update * update * Revert "update" This reverts commit bab6c6c. Co-authored-by: Emisse <[email protected]> Co-authored-by: wrexbe <[email protected]> Co-authored-by: EmoGarbage404 <[email protected]> Co-authored-by: PJBot <[email protected]> Co-authored-by: themias <[email protected]> Co-authored-by: ike709 <[email protected]> Co-authored-by: ike709 <[email protected]> Co-authored-by: metalgearsloth <[email protected]> Co-authored-by: Pieter-Jan Briers <[email protected]> Co-authored-by: Veritius <[email protected]> Co-authored-by: Flipp Syder <[email protected]> Co-authored-by: keronshb <[email protected]> Co-authored-by: metalgearsloth <[email protected]> Co-authored-by: Peptide90 <[email protected]> Co-authored-by: Kara <[email protected]> Co-authored-by: Leon Friedrich <[email protected]> Co-authored-by: metalgearsloth <[email protected]> Co-authored-by: T-Stalker <[email protected]> Co-authored-by: Moony <[email protected]> Co-authored-by: wrexbe <[email protected]> Co-authored-by: TimrodDX <[email protected]> Co-authored-by: 20kdc <[email protected]> Co-authored-by: efzapa <[email protected]> Co-authored-by: Morbo <[email protected]> Co-authored-by: ShuttleEnjoyer <[email protected]> Co-authored-by: DrSmugleaf <[email protected]> Co-authored-by: T-Stalker <[email protected]> Co-authored-by: ElectroJr <[email protected]> Co-authored-by: Vera Aguilera Puerto <[email protected]> Co-authored-by: Ripmorld <[email protected]> Co-authored-by: Visne <[email protected]>
Morb0
added a commit
to Morb0/space-station-14
that referenced
this pull request
Oct 30, 2022
CaptainSqrBeard
pushed a commit
to CaptainSqrBeard/space-station-14
that referenced
this pull request
Jul 7, 2023
* TG-zation: Nukieplanet & Infiltrator + Rus locale fix Co-Authored-By: Ratyyy <[email protected]> * TG Nukeplanet: Removed unused turrets from the pod * TG Infiltrator: Forgot about some decals * Revert locale fix --------- Co-authored-by: Ratyyy <[email protected]>
SlamBamActionman
pushed a commit
to SlamBamActionman/space-station-14
that referenced
this pull request
May 8, 2024
* yamls and oggs * more sounds * more yaml * SPRITE :DDD * FTL :3 * Create full.png * fixed pngs * Update speech_sounds.yml pt1 * Update speech_emote_sounds.yml pt2 * the final bap? * add species components * im a fool * IM TRUELY A FOOL * testing shit on git * a * :blunt: * pain :hidethepain: * :hidethepain: 2 * *chirp * the typo of all time * STRIPE 1 DONE :rivvyhell: * THE TRIMS * test 1 * test 1.1 * Hair and more trims! (Plus they work now) * fuck * temp shit fixed, shouldn't phase now.. .hopefully * collisions fixed :) * hair works * a * fixed a localization * blood time also markings * THE GREAT MARKING SCHISM * fucked up a localization * fuck * attributions * nairod's requests * attributions edit * more attributions shit * Removed laugh, updated attributions * disabled laugh in the voice proto * 🔥 * avali internal temp adjusted :hidethepain: * adds Avali headphones because yeah. (also they render weird) * Revert "adds Avali headphones because yeah. (also they render weird)" This reverts commit 98c7d2f12f96b0050568e44a068eaea54106e3eb.
rbertoche
pushed a commit
to rbertoche/space-station-14
that referenced
this pull request
Aug 25, 2024
* Initial Port * Should fix test fail * Edge with Experimental Supermatter Engine * Update edge.yml * New edge by Colintel * Update edge.yml * Update edge.yml * Physics based air throws * Update base_structureclosets.yml * Updates for review * Hello, this is an asymptote. Divide by zero must be an exit condition. * Adding the clamp back in * better sound looping * I found another small optimization * Another one * guh * Psionic Refactor pt 1 * Last bit * Last one missed * I accidentally sent the DeltaV legacy version of these * Update edge.yml * New Cvar * Update comments for documentation * Apply suggestions from code review Co-authored-by: DEATHB4DEFEAT <[email protected]> * Update supermatter * Finishing Mind Swap rework * Noospheric Zap updating * Almost done * guh * More migrations * Final migrations * Last set of migrations * Update PsionicsSystem.cs * Almost got it, one last bug to squash * slightly more acccurate but still not quite right * Update PyrokinesisPowerSystem.cs * removing some errant instances of potentialpsionic * Revert "removing some errant instances of potentialpsionic" This reverts commit 0597405a48a588c9127e1bdbdca1b3d8aae81732. * Final power update * Update psionicPowers.yml * Update psionic.ftl * some more small tweaks * Update PotentialPsionicComponent.cs * Update Content.Server/Psionics/Abilities/PsionicAbilitiesSystem.cs Co-authored-by: Danger Revolution! <[email protected]> * Update PsionicAbilitiesSystem.cs * remove downstream comments * Giving pyrokinesis back to ifrit, and setting up base caster stat bonuses to roundstart casters * Update familiars.yml * MORE * Update AtmosphereSystem.HighPressureDelta.cs * guh, last push * Fix for objects getting stuck on walls, new CVar for more expensive airflow option. * Update animals.yml * Fix tiny mobs boiling themselves to death * 1984'ing GlobalRollforward (#423) GIVE ME BACK THE TESTS. * Listening Post Earlier Start (#409) # Description This was something that always annoyed me back when I made this for DeltaV. One key feature of the Listening Post was that it would have acted to encourage traitors to actually buy the encryption key bundle, since it had the possibility of letting them get radio support from a listening post. At the time Debug insisted it should only ever spawn extremely late in the around, giving it a sufficiently low weight that it would only appear usually an hour into the round. By this point all of the traitors had either been caught or had already done their thing, thus defeating the entire point of it. It also had an absurdly high minimum player count relative to the actual threat the outpost serves, ensuring that it would never appear on lowpop servers. Seriously not even stationwide lethal threats such as Xenos Ventcritters had as high of a minimum player count. # Changelog :cl: - tweak: Syndicate Listening Posts can now appear any time in a round, and can appear on low-pop servers. * Automatic Changelog Update (#409) * Mirror: Add Prometheus stats for admin count (#323) ## Mirror of PR #26284: [Add Prometheus stats for admin count](https://github.com/space-wizards/space-station-14/pull/26284) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `a1817a12dbb385275f4273c1abf48fac0a989ddd` PR opened by <img src="https://avatars.githubusercontent.com/u/8107459?v=4" width="16"/><a href="https://github.com/PJB3005"> PJB3005</a> at 2024-03-20 10:12:29 UTC --- PR changed 2 files with 106 additions and 1 deletions. The PR had the following labels: - Status: Needs Review --- <details open="true"><summary><h1>Original Body</h1></summary> > Fixes #20828 > > Reports time series for admin count. Counts are separated by state (active, AFK, or deadminned) and admin rank. > > Requires engine master </details> Co-authored-by: SimpleStation14 <Unknown> * Walls/Windows Resprites! (#402) <!-- This is a semi-strict format, you can add/remove sections as needed but the order/format should be kept the same Remove these comments before submitting --> # Walls/Windows Resprites! <!-- Explain this PR in as much detail as applicable Some example prompts to consider: How might this affect the game? The codebase? What might be some alternatives to this? How/Who does this benefit/hurt [the game/codebase]? --> Import the changes that i provided to frontier in PR: https://github.com/new-frontiers-14/frontier-station-14/pull/418 to EE, including part of this PR: https://github.com/new-frontiers-14/frontier-station-14/pull/757 Those Walls/Windows LOOK EXTREMLY MORE BETTER then the old TG walls/windows, Common its 2024! We need DRIP IN ALL WALLS! .yml changes are needed for connection to walls/window and prevent connected from doors, shutters, ect... --- # TODO <!-- A list of everything you have to do before this PR is "complete" You probably won't have to complete everything before merging but it's good to leave future references --> - [x] Import Sprites. - [x] yml changes --- <!-- This is default collapsed, readers click to expand it and see all your media The PR media section can get very large at times, so this is a good way to keep it clean The title is written using HTML tags The title must be within the <summary> tags or you won't see it --> <details><summary><h1>Media</h1></summary> <p>  </p> </details> --- # Changelog <!-- You can add an author after the `:cl:` to change the name that appears in the changelog (ex: `:cl: Death`) Leaving it blank will default to your GitHub display name This includes all available types for the changelog --> :cl: - tweak: Better wall sprites. - tweak: Better window sprites. * Radio Resprites! (#404) <!-- This is a semi-strict format, you can add/remove sections as needed but the order/format should be kept the same Remove these comments before submitting --> # Radio Resprites! <!-- Explain this PR in as much detail as applicable Some example prompts to consider: How might this affect the game? The codebase? What might be some alternatives to this? How/Who does this benefit/hurt [the game/codebase]? --> Radio Respsrites madness changes all the Headset sprites, Radio, Talkwalkies, Beacon and signaller. This also removed the "radio" sprite... well its replace it with the "old-radio". --- # TODO <!-- A list of everything you have to do before this PR is "complete" You probably won't have to complete everything before merging but it's good to leave future references --> - [x] Sprite Import --- <!-- This is default collapsed, readers click to expand it and see all your media The PR media section can get very large at times, so this is a good way to keep it clean The title is written using HTML tags The title must be within the <summary> tags or you won't see it --> <details><summary><h1>Media</h1></summary> <p>  </p> </details> --- # Changelog <!-- You can add an author after the `:cl:` to change the name that appears in the changelog (ex: `:cl: Death`) Leaving it blank will default to your GitHub display name This includes all available types for the changelog --> :cl: - tweak: Radio Resprites, Talkwalkies, Beacon, Headset... - tweak: Radio and uplink radio looks the same, make sure to check what freq the radio is on! * Automatic Changelog Update (#402) * Automatic Changelog Update (#404) * Mirror: Change Syndie Monkey Price 8-6 TC (#243) ## Mirror of PR #26214: [Change Syndie Monkey Price 8-6 TC](https://github.com/space-wizards/space-station-14/pull/26214) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `6095383ce491e9cb4836662f3bc56ee26eee29f6` PR opened by <img src="https://avatars.githubusercontent.com/u/151778459?v=4" width="16"/><a href="https://github.com/FungiFellow"> FungiFellow</a> at 2024-03-17 17:55:32 UTC --- PR changed 1 files with 2 additions and 2 deletions. The PR had the following labels: - No C# --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > I decreased the Price of Monkey reinforcements from 8 to 6, > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > Monkies are awful in combat and anyone can take them out with 1-3 shoves and aren't worth 8TC 90% of the time unless the consience piloting it is robust. > ## Technical details > <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> > > ## Media > <!-- > PRs which make ingame changes (adding clothing, items, new features, etc) are required to have media attached that showcase the changes. > Small fixes/refactors are exempt. > Any media may be used in SS14 progress reports, with clear credit given. > > If you're unsure whether your PR will require media, ask a maintainer. > > Check the box below to confirm that you have in fact seen this (put an X in the brackets, like [X]): > --> > > - [X] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > > ## Breaking changes > <!-- > List any breaking changes, including namespace, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be pasted in #codebase-changes. > --> > > **Changelog** > <!-- > Make players aware of new features and changes that could affect how they play the game by adding a Changelog entry. Please read the Changelog guidelines located at: https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog > --> > > <!-- > Make sure to take this Changelog template out of the comment block in order for it to show up. > :cl: > - add: Added fun! > - remove: Removed fun! > - tweak: Changed fun! > - fix: Fixed fun! > --> > :cl: > - tweak: Changed Monkey Reinf Price to 6TC </details> Co-authored-by: SimpleStation14 <Unknown> * Mirror: Updated the TEG page (#260) ## Mirror of PR #26170: [Updated the TEG page](https://github.com/space-wizards/space-station-14/pull/26170) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `353784bfaed731b8a803a3191e51c9afaf6e5bb4` PR opened by <img src="https://avatars.githubusercontent.com/u/85469138?v=4" width="16"/><a href="https://github.com/Terraspark4941"> Terraspark4941</a> at 2024-03-16 05:21:22 UTC --- PR changed 1 files with 166 additions and 13 deletions. The PR had the following labels: - No C# - Status: Needs Review --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > Updated the TEG page to have actual information/meta about setting up the TEG > Ported from guidebook-cleanup branch on my fork > [ This information has been certified by a TEG-setup expert ] > > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > It made me angry reading the old page and not getting the information that I needed > > ## Media > <!-- > PRs which make ingame changes (adding clothing, items, new features, etc) are required to have media attached that showcase the changes. > Small fixes/refactors are exempt. > Any media may be used in SS14 progress reports, with clear credit given. > > If you're unsure whether your PR will require media, ask a maintainer. > > Check the box below to confirm that you have in fact seen this (put an X in the brackets, like [X]): > --> > > - [X] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > > **Changelog** > <!-- > Make players aware of new features and changes that could affect how they play the game by adding a Changelog entry. Please read the Changelog guidelines located at: https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog > --> > > :cl: > - tweak: The TEG page in the guidebook has been updated with proper information! > > </details> Co-authored-by: SimpleStation14 <Unknown> Co-authored-by: VMSolidus <[email protected]> * Mirror: Red Neck Gaiter (#214) ## Mirror of PR #25891: [Red Neck Gaiter](https://github.com/space-wizards/space-station-14/pull/25891) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `1938768ea69ad2f69758036816142a205552eb63` PR opened by <img src="https://avatars.githubusercontent.com/u/110078045?v=4" width="16"/><a href="https://github.com/Nairodian"> Nairodian</a> at 2024-03-06 22:32:25 UTC --- PR changed 8 files with 41 additions and 0 deletions. The PR had the following labels: - No C# - Changes: Sprites --- <details open="true"><summary><h1>Original Body</h1></summary> > ## About the PR > Real simple. Adds a (shameless) recolor of the existing neck gaiter in a red variant and adds two of it to the AutoDrobe > > ## Why / Balance > I felt like a proper red face mask style was missing to go with the new cowboy stuff. > > ## Media >  > - [X] I have added screenshots/videos to this PR showcasing its changes ingame. > > **Changelog** > :cl: > - add: Added a new red neck gaiter to the AutoDrobe. > </details> --------- Co-authored-by: SimpleStation14 <Unknown> Co-authored-by: VMSolidus <[email protected]> * Mirror: Add PVS command permissions (#207) ## Mirror of PR #26124: [Add PVS command permissions](https://github.com/space-wizards/space-station-14/pull/26124) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `361092a40b110049b85187e935f4eb531f36a99f` PR opened by <img src="https://avatars.githubusercontent.com/u/60421075?v=4" width="16"/><a href="https://github.com/ElectroJr"> ElectroJr</a> at 2024-03-15 03:05:58 UTC --- PR changed 1 files with 1 additions and 0 deletions. The PR had the following labels: - No C# - Status: Needs Review --- <details open="true"><summary><h1>Original Body</h1></summary> > Requires https://github.com/space-wizards/RobustToolbox/pull/4958 </details> Co-authored-by: SimpleStation14 <Unknown> Co-authored-by: VMSolidus <[email protected]> * Mirror: fix admin verb to set unspawned ballisic ammo count (#375) ## Mirror of PR #26411: [fix admin verb to set unspawned ballisic ammo count](https://github.com/space-wizards/space-station-14/pull/26411) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `451890b85b49e17a0019d107db4a31a48cdd3518` PR opened by <img src="https://avatars.githubusercontent.com/u/107586145?v=4" width="16"/><a href="https://github.com/IProduceWidgets"> IProduceWidgets</a> at 2024-03-24 21:06:57 UTC --- PR changed 2 files with 15 additions and 3 deletions. The PR had the following labels: - Status: Needs Review --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > Fixed #26362 > > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > > ## Technical details > <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> > I made the UpdateBallisticAppearance function public, I can't think of any reason that's a bad idea. > > ## Media > <!-- > PRs which make ingame changes (adding clothing, items, new features, etc) are required to have media attached that showcase the changes. > Small fixes/refactors are exempt. > Any media may be used in SS14 progress reports, with clear credit given. > > If you're unsure whether your PR will require media, ask a maintainer. > > Check the box below to confirm that you have in fact seen this (put an X in the brackets, like [X]): > --> > > - [X] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > > ## Breaking changes > <!-- > List any breaking changes, including namespace, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be pasted in #codebase-changes. > --> > > **Changelog** > <!-- > Make players aware of new features and changes that could affect how they play the game by adding a Changelog entry. Please read the Changelog guidelines located at: https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog > --> > > <!-- > Make sure to take this Changelog template out of the comment block in order for it to show up. > :cl: > - add: Added fun! > - remove: Removed fun! > - tweak: Changed fun! > - fix: Fixed fun! > --> > :ADMIN: > - fix: setting ballistic ammo counts for a magazine should no longer be able to crash your game. </details> Co-authored-by: SimpleStation14 <Unknown> * Glorious Tools! (#407) <!-- This is a semi-strict format, you can add/remove sections as needed but the order/format should be kept the same Remove these comments before submitting --> # Glorious Tools! <!-- Explain this PR in as much detail as applicable Some example prompts to consider: How might this affect the game? The codebase? What might be some alternatives to this? How/Who does this benefit/hurt [the game/codebase]? --> Add//Change a bunch of tools sprites that was in the tool category to make them fit better in general, Old TG... please update.exe Anywho here they are! --- # TODO <!-- A list of everything you have to do before this PR is "complete" You probably won't have to complete everything before merging but it's good to leave future references --> - [x] Import Sprites --- <!-- This is default collapsed, readers click to expand it and see all your media The PR media section can get very large at times, so this is a good way to keep it clean The title is written using HTML tags The title must be within the <summary> tags or you won't see it --> <details><summary><h1>Media</h1></summary> <p>  </p> </details> --- # Changelog <!-- You can add an author after the `:cl:` to change the name that appears in the changelog (ex: `:cl: Death`) Leaving it blank will default to your GitHub display name This includes all available types for the changelog --> :cl: - tweak: New Tools Sprites! * Mirror: new book - Tales of a Tired Janitor (#278) ## Mirror of PR #24441: [new book - Tales of a Tired Janitor](https://github.com/space-wizards/space-station-14/pull/24441) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `0a6921d5ef90ebaaf1e054178f2889889eea661c` PR opened by <img src="https://avatars.githubusercontent.com/u/149967078?v=4" width="16"/><a href="https://github.com/Boaz1111"> Boaz1111</a> at 2024-01-23 09:28:08 UTC --- PR changed 2 files with 22 additions and 0 deletions. The PR had the following labels: - No C# --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > I added a new book, as requested by someone in the discord. This book is about the life of a janitor working aboard a (presumably NT) space station "14". They describe the things they have to deal with, the disrespect from others, the lack of good equipment. > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > More variety in books, especially books indirectly talking about life on a space station, and the jobs on said station. > ## Technical details > <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> > > ## Media > <!-- > PRs which make ingame changes (adding clothing, items, new features, etc) are required to have media attached that showcase the changes. > Small fixes/refactors are exempt. > Any media may be used in SS14 progress reports, with clear credit given. > > If you're unsure whether your PR will require media, ask a maintainer. > > Check the box below to confirm that you have in fact seen this (put an X in the brackets, like [X]): > --> > > - [X] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > > ## Breaking changes > <!-- > List any breaking changes, including namespace, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be pasted in #codebase-changes. > --> > > **Changelog** > <!-- > Make players aware of new features and changes that could affect how they play the game by adding a Changelog entry. Please read the Changelog guidelines located at: https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog > --> > > <!-- > Make sure to take this Changelog template out of the comment block in order for it to show up. > :cl: > - add: Added fun! > - remove: Removed fun! > - tweak: Changed fun! > - fix: Fixed fun! > --> > no cl </details> Co-authored-by: SimpleStation14 <Unknown> Co-authored-by: VMSolidus <[email protected]> * Automatic Changelog Update (#407) * Add More Suggested VSCode Extensions (#414) Co-authored-by: Danger Revolution! <[email protected]> * Mirror: Obsolete `Logger` cleanup for `EntitySystem`s part 2 (#237) ## Mirror of PR #26159: [Obsolete `Logger` cleanup for `EntitySystem`s part 2](https://github.com/space-wizards/space-station-14/pull/26159) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `7d275a4b5e4188db424cc417c609dced3f9aca89` PR opened by <img src="https://avatars.githubusercontent.com/u/27449516?v=4" width="16"/><a href="https://github.com/LordCarve"> LordCarve</a> at 2024-03-15 20:15:41 UTC --- PR changed 14 files with 36 additions and 25 deletions. The PR had the following labels: - Status: Needs Review --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > Part 2 of 2, continuation of #25941 > Gets rid of the remaining obsolete `Logger` method calls from all `EntitySystem`s and uses the expected `Log` to get at the proper sawmill. > > In particular: > 1. Make the `ExamineSystemShared`'s `InRangeUnObstructed` non-`static` (so finally able to use instance-based `Log` rather than `Logger`) and inject dependency to all systems that were using it as `static`. > 2. Adjust 4 more `EntitySystem`s to use `Log` rather than `Logger` that were missed in the previous PR. > > Tested that the game runs and the affected systems direct logs to the correct sawmill. > > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > Using Logger directly for logging is marked obsolete. Brings some order to logs (i.e. all `EntitySystem` logs start with a preceding `system.`). > > ## Technical details > <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> > I'm pretty sure `ExamineSystemShared`'s `InRangeUnObstructed` not being `static` is the intended way since it being `static` dodges the IoC entirely. It even has dirty hacks such as getting the occluder system inside to make it happen. I didn't fix any of that as it's beyond the scope of this PR, but it's another thing that needs improving. > > These are the changes to the log sawmills: > `ExamineSystemShared.cs`: BEFORE: `root` -> NEW: `system.examine` > `AtmosphereSystem.Monstermos.cs`: BEFORE: `root` -> NEW: `system.atmosphere` > `TypingIndicatorSystem.cs`: BEFORE: `root` -> NEW: `system.typing_indicator` > `PiratesRuleSystem.cs` BEFORE: `pirates` -> NEW: `system.pirates_rule` > `TabletopSystem.Session.cs` BEFORE: `root` -> NEW: `system.tabletop` > > ## Media > <!-- > PRs which make ingame changes (adding clothing, items, new features, etc) are required to have media attached that showcase the changes. > Small fixes/refactors are exempt. > Any media may be used in SS14 progress reports, with clear credit given. > > If you're unsure whether your PR will require media, ask a maintainer. > > Check the box below to confirm that you have in fact seen this (put an X in the brackets, like [X]): > --> > > - [X] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > > ## Breaking changes > <!-- > List any breaking changes, including namespace, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be pasted in #codebase-changes. > --> > Some logs now fall under a different sawmill (more precise). Any software that analyzes logs and makes assumptions on which sawmill do these logs fall to will need to be adjusted. </details> --------- Signed-off-by: VMSolidus <[email protected]> Co-authored-by: SimpleStation14 <Unknown> Co-authored-by: VMSolidus <[email protected]> * Mirror: CargoConsoleMenu localization (#127) ## Mirror of PR #25931: [CargoConsoleMenu localization](https://github.com/space-wizards/space-station-14/pull/25931) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `6e38b992cfc607e09178efc178b86f35152f0cde` PR opened by <img src="https://avatars.githubusercontent.com/u/87994977?v=4" width="16"/><a href="https://github.com/modern-nm"> modern-nm</a> at 2024-03-08 14:46:29 UTC PR merged by <img src="https://avatars.githubusercontent.com/u/19864447?v=4" width="16"/><a href="https://github.com/web-flow"> web-flow</a> at 2024-03-09 06:56:40 UTC --- PR changed 20 files with 211 additions and 195 deletions. The PR had the following labels: - Changes: UI --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > This PR adds localization capability for CargoConsoleMenu (name of entity: ComputerCargoOrders) > > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > > Please let me tell you a story of my vision. First i decided to make these changes on one of russian community servers. But taking into account future changes of .yml files by space-wizards community (they are regularly added to our space-station build), we will have to constantly edit xml files to remove duplicate categories — imagine someone added cargoproduct with category "Fun", when we have tons of items with category "Развлечения". > > To summarize: my PR makes possible to localize categories of "cargoproduct" and makes communities do less work when upstream comes > > ## Technical details > <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> > > New code considers strings comparisons of prototype.Category (Content.Client/Cargo/UI/CargoConsoleMenu.xaml.cs) using Loc.GetString(...). And that's all. > > ## Media > <!-- > PRs which make ingame changes (adding clothing, items, new features, etc) are required to have media attached that showcase the changes. > Small fixes/refactors are exempt. > Any media may be used in SS14 progress reports, with clear credit given. > > If you're unsure whether your PR will require media, ask a maintainer. > > Check the box below to confirm that you have in fact seen this (put an X in the brackets, like [X]): > --> > Off course there are no visible changes on eng-localization > >  > > That's how these changes look like on our community build, using other .ftl file > >  > > > - [x] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > > ## Breaking changes > <!-- > List any breaking changes, including namespace, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be pasted in #codebase-changes. > --> > > > .yml > - every category of type "cargoProduct" was edited to "cargoproduct-category-name-{categoryName}" > > .ftl > - file "cargoproduct-categories.ftl" was added to english localization to localize categories of cargoProduct > > .cs > - CargoConsoleMenu.xaml.cs got tweaks which prevent issues with strings comparisons > > **Changelog** > <!-- > Make players aware of new features and changes that could affect how they play the game by adding a Changelog entry. Please read the Changelog guidelines located at: https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog > --> > </details> --------- Signed-off-by: VMSolidus <[email protected]> Co-authored-by: MODERN <[email protected]> Co-authored-by: VMSolidus <[email protected]> * Updates spawners with new content (#86) ## Mirror of PR #1032: [Updates spawners with new content](https://github.com/DeltaV-Station/Delta-v/pull/1032) from <img src="https://avatars.githubusercontent.com/u/131613340?v=4" alt="DeltaV-Station" width="22"/> [DeltaV-Station](https://github.com/DeltaV-Station)/[Delta-v](https://github.com/DeltaV-Station/Delta-v) <aside>PR opened by <img src="https://avatars.githubusercontent.com/u/107660393?v=4" width="16"/><a href="https://github.com/IamVelcroboy"> IamVelcroboy</a> at 2024-03-28 21:03:53 UTC</aside> <aside>PR merged by <img src="https://avatars.githubusercontent.com/u/107660393?v=4" width="16"/><a href="https://github.com/IamVelcroboy"> IamVelcroboy</a> at 2024-03-28 21:28:31 UTC</aside> <sup> `5e397c6e7b2d2513f49948fbba1eb1d658fe4a9e` </sup> --- PR changed 0 files with 0 additions and 0 deletions. The PR had the following labels: - Changes: YML --- <details open="true"><summary><h1>Original Body</h1></summary> > ## About the PR > Title. Updates box, device, hat, machinepart, and seed spawners. > Will do Items later. > > ## Why / Balance > Just catching up </details> --------- Co-authored-by: Velcroboy <[email protected]> Co-authored-by: VMSolidus <[email protected]> Co-authored-by: Danger Revolution! <[email protected]> * Update PsionicRegenerationPowerSystem.cs * Revert "Merge branch 'VMSolidus-Psionic-Power-Refactor'" This reverts commit 15fc457e8f1ffa3a05966566dff93dbe6994310a, reversing changes made to c62f777aee0c5e28df70953f77de950009e42c13. * Update PsionicRegenerationPowerSystem.cs * aaaaaaaaa * Update PsionicRegenerationPowerSystem.cs * fun pvs fixes * Mirror: Fixes store purchase events and adds support to raise a directed event (#364) ## Mirror of PR #26389: [Fixes store purchase events and adds support to raise a directed event](https://github.com/space-wizards/space-station-14/pull/26389) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `4dced51f0d8d008714a14675b48c8fa2b7fa0ace` PR opened by <img src="https://avatars.githubusercontent.com/u/54602815?v=4" width="16"/><a href="https://github.com/keronshb"> keronshb</a> at 2024-03-24 14:16:44 UTC --- PR changed 2 files with 8 additions and 3 deletions. The PR had the following labels: - Status: Needs Review --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > > When testing around some things with the magic PR I found that the purchase event wasn't being compared correctly. Also I added support to raise the purchase event directed at the buyer instead of just a broadcast event. > > ## Technical details > <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> > The equals method will now check for purchase event type instead of comparing the references. To make this stronger we should talk about creating a base store purchase event class. > > For directing the event I added a bool to raise on user and we check if that's true. > > ## Media > <!-- > PRs which make ingame changes (adding clothing, items, new features, etc) are required to have media attached that showcase the changes. > Small fixes/refactors are exempt. > Any media may be used in SS14 progress reports, with clear credit given. > > If you're unsure whether your PR will require media, ask a maintainer. > > Check the box below to confirm that you have in fact seen this (put an X in the brackets, like [X]): > --> > > - [x] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase </details> Co-authored-by: SimpleStation14 <Unknown> * Mirror: Adds logging for refunds (#275) ## Mirror of PR #26274: [Adds logging for refunds](https://github.com/space-wizards/space-station-14/pull/26274) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `85f4b43db1c0256e6d4c48a01558e8cc0a883ada` PR opened by <img src="https://avatars.githubusercontent.com/u/54602815?v=4" width="16"/><a href="https://github.com/keronshb"> keronshb</a> at 2024-03-19 23:42:22 UTC --- PR changed 2 files with 4 additions and 0 deletions. The PR had the following labels: - Status: Needs Review --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > > Refunds now have logging > > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > > Good for admins to keep track of. > > ## Technical details > <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> > A Store Refund entry was added into the logging enum and a log entry is made when a refund is successful. </details> Signed-off-by: VMSolidus <[email protected]> Co-authored-by: SimpleStation14 <Unknown> Co-authored-by: VMSolidus <[email protected]> * Mirror: Fix artifact report guidebook info (#268) ## Mirror of PR #26252: [Fix artifact report guidebook info](https://github.com/space-wizards/space-station-14/pull/26252) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `e70928fad8c849ac0fd48da1415b6b134f9336a8` PR opened by <img src="https://avatars.githubusercontent.com/u/32827189?v=4" width="16"/><a href="https://github.com/Vermidia"> Vermidia</a> at 2024-03-19 03:17:41 UTC --- PR changed 1 files with 1 additions and 1 deletions. The PR had the following labels: - No C# - Status: Needs Review --- <details open="true"><summary><h1>Original Body</h1></summary> > Fix conflicting info > > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > > The line about current value still treated extracting points from artifacts as destroying them, so I've changed it to clarify how it works better. > > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > > Really confusing when part of the guide tells you to always extract and the other says to be careful since it'll get destroyed. > > ## Technical details > <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> > > ## Media > <!-- > PRs which make ingame changes (adding clothing, items, new features, etc) are required to have media attached that showcase the changes. > Small fixes/refactors are exempt. > Any media may be used in SS14 progress reports, with clear credit given. > > If you're unsure whether your PR will require media, ask a maintainer. > > Check the box below to confirm that you have in fact seen this (put an X in the brackets, like [X]): > --> > > - [ ] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > > ## Breaking changes > <!-- > List any breaking changes, including namespace, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be pasted in #codebase-changes. > --> > > **Changelog** > <!-- > Make players aware of new features and changes that could affect how they play the game by adding a Changelog entry. Please read the Changelog guidelines located at: https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog > --> > :cl: > - tweak: Made the Artifact Reports page up to date with current Xenoarchaeology > <!-- > Make sure to take this Changelog template out of the comment block in order for it to show up. > --> > </details> Signed-off-by: VMSolidus <[email protected]> Co-authored-by: SimpleStation14 <Unknown> Co-authored-by: VMSolidus <[email protected]> * Mirror: More good looking inventory part 2.2 (instruments version) (#189) ## Mirror of PR #26090: [More good looking inventory part 2.2 (instruments version)](https://github.com/space-wizards/space-station-14/pull/26090) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `91aa6445714d6b833474fcb911c4c8555a54f799` PR opened by <img src="https://avatars.githubusercontent.com/u/124214523?v=4" width="16"/><a href="https://github.com/lzk228"> lzk228</a> at 2024-03-13 18:52:29 UTC --- PR changed 4 files with 12 additions and 4 deletions. The PR had the following labels: - No C# --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > - media > - fix tophat name > > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > > ## Technical details > <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> > > ## Media > <!-- > PRs which make ingame changes (adding clothing, items, new features, etc) are required to have media attached that showcase the changes. > Small fixes/refactors are exempt. > Any media may be used in SS14 progress reports, with clear credit given. > > If you're unsure whether your PR will require media, ask a maintainer. > > Check the box below to confirm that you have in fact seen this (put an X in the brackets, like [X]): > --> >  > > - [X] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > > ## Breaking changes > <!-- > List any breaking changes, including namespace, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be pasted in #codebase-changes. > --> > > **Changelog** > <!-- > Make players aware of new features and changes that could affect how they play the game by adding a Changelog entry. Please read the Changelog guidelines located at: https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog > --> > no cl no fun > <!-- > Make sure to take this Changelog template out of the comment block in order for it to show up. > :cl: > - add: Added fun! > - remove: Removed fun! > - tweak: Changed fun! > - fix: Fixed fun! > --> > </details> Signed-off-by: VMSolidus <[email protected]> Co-authored-by: SimpleStation14 <Unknown> Co-authored-by: VMSolidus <[email protected]> * Mirror: Syringes that spawn with content start in inject mode (#129) ## Mirror of PR #25881: [Syringes that spawn with content start in inject mode](https://github.com/space-wizards/space-station-14/pull/25881) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `5cb48c922fa7236d07b463f0c38ada2d5805e54b` PR opened by <img src="https://avatars.githubusercontent.com/u/58439124?v=4" width="16"/><a href="https://github.com/Plykiya"> Plykiya</a> at 2024-03-06 13:43:59 UTC PR merged by <img src="https://avatars.githubusercontent.com/u/19864447?v=4" width="16"/><a href="https://github.com/web-flow"> web-flow</a> at 2024-03-09 10:19:03 UTC --- PR changed 3 files with 25 additions and 23 deletions. The PR had the following labels: - Status: Needs Review --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > Made it so that syringes that spawn with content start out in inject mode rather than draw mode. Also got rid of unnecessary DataField names if they matched. > > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > Grab bic syringe from medkit, use it on patient, it's in draw mode by default, cry. > > ## Technical details > <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> > I added a new yml entity for prefilled syringes that starts in inject mode. > > I attempted to do it the "smart way" by changing the ComponentInit code to check for the solution amount and toggle based on that, but for some reason the solution was returning false on the server-side but not on the client-side so there was a desync in the Inject state. Couldn't really figure out how to fix it, so I just went with the dumb simple method instead. > > ## Media > <!-- > PRs which make ingame changes (adding clothing, items, new features, etc) are required to have media attached that showcase the changes. > Small fixes/refactors are exempt. > Any media may be used in SS14 progress reports, with clear credit given. > > If you're unsure whether your PR will require media, ask a maintainer. > > Check the box below to confirm that you have in fact seen this (put an X in the brackets, like [X]): > --> > > - [ X ] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > > ## Breaking changes > <!-- > List any breaking changes, including namespace, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be pasted in #codebase-changes. > --> > None > > **Changelog** > <!-- > Make players aware of new features and changes that could affect how they play the game by adding a Changelog entry. Please read the Changelog guidelines located at: https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog > --> > > <!-- > Make sure to take this Changelog template out of the comment block in order for it to show up. > :cl: > - add: Added fun! > - remove: Removed fun! > - tweak: Changed fun! > - fix: Fixed fun! > --> > :cl: > - tweak: Pre-filled syringes start in inject mode now. </details> Signed-off-by: VMSolidus <[email protected]> Co-authored-by: Plykiya <[email protected]> Co-authored-by: VMSolidus <[email protected]> * Mirror: Fix vox custom sprites (#186) ## Mirror of PR #25989: [Fix vox custom sprites](https://github.com/space-wizards/space-station-14/pull/25989) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `8a77722f91a94846f0027f56b8d8f2ec76254d81` PR opened by <img src="https://avatars.githubusercontent.com/u/35878406?v=4" width="16"/><a href="https://github.com/Errant-4"> Errant-4</a> at 2024-03-11 09:29:16 UTC --- PR changed 1 files with 2 additions and 0 deletions. The PR had the following labels: - No C# - Status: Needs Review --- <details open="true"><summary><h1>Original Body</h1></summary> > ## About the PR > Clothing with custom sprites for vox have been displaying the default sprites due to a component accident. > > ## Media > - [X] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > > **Changelog** > :cl: Errant > - fix: Clothes with alternate sprites for vox once again show the alternate sprites, instead of the defaults. > </details> Co-authored-by: SimpleStation14 <Unknown> * Mirror: Code cleanup: Purge calls to obsolete EntityCoordinates methods (#289) ## Mirror of PR #26292: [Code cleanup: Purge calls to obsolete EntityCoordinates methods](https://github.com/space-wizards/space-station-14/pull/26292) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `f4cb02fb0ca385c858569c07c51afb0d24ade949` PR opened by <img src="https://avatars.githubusercontent.com/u/85356?v=4" width="16"/><a href="https://github.com/Tayrtahn"> Tayrtahn</a> at 2024-03-20 16:04:43 UTC --- PR changed 34 files with 70 additions and 56 deletions. The PR had the following labels: - Status: Needs Review --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > Cleaned up some outdated code. > > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > Clean code is happy code. > > ## Technical details > <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> > Updated all calls to obsolete EntityCoordinates methods (ToMap, ToMapPos, FromMap, ToVector2i, InRange) to non-obsolete ones (by passing in SharedTransformSystem as an arg). > > ## Media > <!-- > PRs which make ingame changes (adding clothing, items, new features, etc) are required to have media attached that showcase the changes. > Small fixes/refactors are exempt. > Any media may be used in SS14 progress reports, with clear credit given. > > If you're unsure whether your PR will require media, ask a maintainer. > > Check the box below to confirm that you have in fact seen this (put an X in the brackets, like [X]): > --> > Code > - [X] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > > ## Breaking changes > <!-- > List any breaking changes, including namespace, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be pasted in #codebase-changes. > --> > > **Changelog** > <!-- > Make players aware of new features and changes that could affect how they play the game by adding a Changelog entry. Please read the Changelog guidelines located at: https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog > --> > > <!-- > Make sure to take this Changelog template out of the comment block in order for it to show up. > :cl: > - add: Added fun! > - remove: Removed fun! > - tweak: Changed fun! > - fix: Fixed fun! > --> > </details> --------- Signed-off-by: VMSolidus <[email protected]> Co-authored-by: SimpleStation14 <Unknown> Co-authored-by: VMSolidus <[email protected]> * Mirror: Snore is a trait now (#299) ## Mirror of PR #26322: [Snore is a trait now](https://github.com/space-wizards/space-station-14/pull/26322) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `3b3b874dd9222770da616ba07277842d6b7a09be` PR opened by <img src="https://avatars.githubusercontent.com/u/124214523?v=4" width="16"/><a href="https://github.com/lzk228"> lzk228</a> at 2024-03-21 23:18:00 UTC --- PR changed 4 files with 24 additions and 1 deletions. The PR had the following labels: --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > Title. > Snore sound is emitting with trait. Without trait not. > > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > Someone told me that snoring is a disease, and not every should have it so i decided to do this pr. > > ## Technical details > <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> > > ## Media > <!-- > PRs which make ingame changes (adding clothing, items, new features, etc) are required to have media attached that showcase the changes. > Small fixes/refactors are exempt. > Any media may be used in SS14 progress reports, with clear credit given. > > If you're unsure whether your PR will require media, ask a maintainer. > > Check the box below to confirm that you have in fact seen this (put an X in the brackets, like [X]): > --> > > - [ ] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > > ## Breaking changes > <!-- > List any breaking changes, including namespace, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be pasted in #codebase-changes. > --> > > **Changelog** > <!-- > Make players aware of new features and changes that could affect how they play the game by adding a Changelog entry. Please read the Changelog guidelines located at: https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog > --> > > > Make sure to take this Changelog template out of the comment block in order for it to show up. > :cl: > - tweak: Snoring is now a trait in character preference menu. > > </details> Co-authored-by: SimpleStation14 <Unknown> * Mirror: Sanitize "ig" (#298) ## Mirror of PR #26328: [Sanitize "ig"](https://github.com/space-wizards/space-station-14/pull/26328) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `4f816b4b2f74db8da32cd157110df538e50eed1a` PR opened by <img src="https://avatars.githubusercontent.com/u/77215380?v=4" width="16"/><a href="https://github.com/Doctor-Cpu"> Doctor-Cpu</a> at 2024-03-22 05:20:30 UTC --- PR changed 2 files with 7 additions and 3 deletions. The PR had the following labels: - No C# --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > "ig" gets replaced with "i guess" > > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > Common slang online which I've seen being attempted to be used before. > > ## Technical details > <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> > N/A > > ## Media > <!-- > PRs which make ingame changes (adding clothing, items, new features, etc) are required to have media attached that showcase the changes. > Small fixes/refactors are exempt. > Any media may be used in SS14 progress reports, with clear credit given. > > If you're unsure whether your PR will require media, ask a maintainer. > > Check the box below to confirm that you have in fact seen this (put an X in the brackets, like [X]): > --> > > - [X] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > > ## Breaking changes > <!-- > List any breaking changes, including namespace, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be pasted in #codebase-changes. > --> > N/A > > **Changelog** > <!-- > Make players aware of new features and changes that could affect how they play the game by adding a Changelog entry. Please read the Changelog guidelines located at: https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog > --> > > <!-- > Make sure to take this Changelog template out of the comment block in order for it to show up. > :cl: > - add: Added fun! > - remove: Removed fun! > - tweak: Changed fun! > - fix: Fixed fun! > --> > Don't feel like one is needed. </details> Co-authored-by: SimpleStation14 <Unknown> * Mirror: Fix placement mode on chairs (#183) ## Mirror of PR #26041: [Fix placement mode on chairs](https://github.com/space-wizards/space-station-14/pull/26041) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `bcc147634af1fea7b5f53f18d136f44ed46cb053` PR opened by <img src="https://avatars.githubusercontent.com/u/107660393?v=4" width="16"/><a href="https://github.com/IamVelcroboy"> IamVelcroboy</a> at 2024-03-12 14:45:33 UTC --- PR changed 1 files with 8 additions and 7 deletions. The PR had the following labels: - No C# --- <details open="true"><summary><h1>Original Body</h1></summary> > ## About the PR > Placement mode on chairs was donked up a little bit recently. This returns the ability to free place certain(unanchored) chairs while mapping. > > ## Why / Balance > More dynamic mapping > > ## Technical details > n/a > > ## Media > - [x] I have added screenshots/videos to this PR showcasing its changes in-game, **or** this PR does not require an in-game showcase > > ## Breaking changes > n/a > > **Changelog** > n/a </details> Signed-off-by: VMSolidus <[email protected]> Co-authored-by: SimpleStation14 <Unknown> Co-authored-by: VMSolidus <[email protected]> * Mirror: Fix mice steering (#134) ## Mirror of PR #25965: [Fix mice steering](https://github.com/space-wizards/space-station-14/pull/25965) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `819ec6361d0d2792b43357a6c45f8c95cb08d9ed` PR opened by <img src="https://avatars.githubusercontent.com/u/31366439?v=4" width="16"/><a href="https://github.com/metalgearsloth"> metalgearsloth</a> at 2024-03-10 14:57:30 UTC PR merged by <img src="https://avatars.githubusercontent.com/u/19864447?v=4" width="16"/><a href="https://github.com/web-flow"> web-flow</a> at 2024-03-10 15:41:42 UTC --- PR changed 1 files with 24 additions and 1 deletions. The PR had the following labels: --- <details open="true"><summary><h1>Original Body</h1></summary> > Thinks there's obstacles when there isn't. Blending exposed it but it was an issue before. > > > :cl: > - fix: Fix NPC mouse movement. > </details> Co-authored-by: metalgearsloth <[email protected]> Co-authored-by: VMSolidus <[email protected]> * Mirror: Create DeviceNetworkJammerComponent & System as a general way for entities to act as jammers (#382) ## Mirror of PR #26342: [Create DeviceNetworkJammerComponent & System as a general way for entities to act as jammers](https://github.com/space-wizards/space-station-14/pull/26342) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `266cc85f57c883b3a604a66da91d94bb1e18ec5d` PR opened by <img src="https://avatars.githubusercontent.com/u/32041239?v=4" width="16"/><a href="https://github.com/nikthechampiongr"> nikthechampiongr</a> at 2024-03-22 19:17:23 UTC --- PR changed 7 files with 91 additions and 25 deletions. The PR had the following labels: - Status: Needs Review --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > This PR creates the DeviceNetworkJammerComponent & System as a general way for entities to act as jammers for the DeviceNetwork. > > Additionally it adjusts the JammerSystem for the radio jammer to use this, and rips out the previous special code for jamming suit sensors. > > As a result of this, the radio jammer can now additionally jam the suit sensor server itself from receiving DeviceNetwork packets. > > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > This pr was requested by a maintainer. > > Additionally a general jamming system can have some utility in the future. E.g. an artifact effect. > ## Technical details > <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> > > Whenever a device attempts to send a packet, the > DeviceNetworkJammerSystem listens for the BeforePacketSentEvent. > From there if any entity with the jammer component is within range of > either the sender or receiver of the packet the event will be cancelled. > Additionally jammers can only block packets in certain networks. If a > packet is not being transmitted in one of the networks it can block then > even if the jammer is in range the event will not be cancelled. > > The range is stored in the jammer c…
iaada
pushed a commit
to iaada/space-station-14
that referenced
this pull request
Sep 2, 2024
added pride cloaks in the uniform printer
Unisol
added a commit
to Unisol/ss14
that referenced
this pull request
Nov 21, 2024
* added RSC rifle crate as cargo purchase * replaced placeholder RSC texture with one supplied by thesaladmancer * added stripper clip recipe to relevant lathes * fixed test failures * clarified access requirements in description
Zap527
pushed a commit
to Zap527/space-station-14
that referenced
this pull request
Nov 26, 2024
Quantum-cross
pushed a commit
to Quantum-cross/space-station-14
that referenced
this pull request
Jan 23, 2025
…-Red-Topicals Security topicals
Quantum-cross
pushed a commit
to Quantum-cross/space-station-14
that referenced
this pull request
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FANCY.