Changes required for component tree engine PR #13109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElectroJr
added
the
S: Needs Engine PR Merged
ElectroJr
commented
Dec 20, 2022
Comment on lines
129
to
-131
| - type: Occluder | ||
| sizeX: 32 | ||
| sizeY: 32 |
There was a problem hiding this comment.
Apparently these were old data fields that the linter is only now erroring on because the occluder component is no longer abstract?
I have NFI what they were for, I guess they were meant to be occluder bounds scaled by pixels per meter?
1 task
…on-14 into generalized-component-trees
Merged
1 task
rbertoche
pushed a commit
to rbertoche/space-station-14
that referenced
this pull request
Jan 16, 2023
moonheart08
pushed a commit
to moonheart08/space-station-14
that referenced
this pull request
Mar 16, 2023
) * Changes required for component tree engine PR (space-wizards#13109) * Changes required for component tree engine PR Co-authored-by: Leon Friedrich <[email protected]> Co-authored-by: lunar-crater-ex <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires space-wizards/RobustToolbox/pull/3598