Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wooden fence gates are mixed up. #26363

Closed
KingOnBudget opened this issue Mar 23, 2024 · 1 comment
Closed

Wooden fence gates are mixed up. #26363

KingOnBudget opened this issue Mar 23, 2024 · 1 comment
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item. D3: Low Difficulty: Some codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. T: Bugfix Type: Bugs and/or bugfixes

Comments

@KingOnBudget
Copy link

KingOnBudget commented Mar 23, 2024

Description

Small wooden fence gate will make a tall wooden fence gate and vice versa

[Screenshots

https://medal.tv/tr/games/space-station-14/clips/22Efnh0ciJR4Gj/d1337Li7pCA1?invite=cr-MSx5RFcsMjAyMDUyNjA0LA

Additional context
I hate medal!!

@UbaserB UbaserB added T: Bugfix Type: Bugs and/or bugfixes P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. D3: Low Difficulty: Some codebase knowledge required. labels Mar 24, 2024
@wrexbe
Copy link
Contributor

wrexbe commented Mar 31, 2024

Was fixed in PR #26409

@wrexbe wrexbe closed this as completed Mar 31, 2024
DangerRevolution pushed a commit to Simple-Station/Einstein-Engines that referenced this issue May 13, 2024
## Mirror of PR #26409: [Fix Small wooden fence gate
sprites](space-wizards/space-station-14#26409)
from <img src="https://avatars.githubusercontent.com/u/10567778?v=4"
alt="space-wizards" width="22"/>
[space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14)

###### `92ab9a8a01ab1cc57bbb449501bed3b77d19b327`

PR opened by <img
src="https://avatars.githubusercontent.com/u/27281377?v=4"
width="16"/><a href="https://github.com/Luminighty"> Luminighty</a> at
2024-03-24 20:06:35 UTC

---

PR changed 3 files with 3 additions and 3 deletions.

The PR had the following labels:
- No C#
- Changes: Sprites


---

<details open="true"><summary><h1>Original Body</h1></summary>

> <!-- Please read these guidelines before opening your PR:
https://docs.spacestation14.io/en/getting-started/pr-guideline -->
> <!-- The text between the arrows are comments - they will not be
visible on your PR. -->
> 
> ## About the PR
> <!-- What did you change in this PR? -->
> 
> Fixed the sprite for the Wooden Fence gates
> 
> ## Why / Balance
> <!-- Why was it changed? Link any discussions or issues here. Please
discuss how this would affect game balance. -->
> 
> space-wizards/space-station-14#26363
> 
> ## Technical details
> <!-- If this is a code change, summarize at high level how your new
code works. This makes it easier to review. -->
> 
> Both the files and the prototype data was flipped
> 
> ## Media
> <!-- 
> PRs which make ingame changes (adding clothing, items, new features,
etc) are required to have media attached that showcase the changes.
> Small fixes/refactors are exempt.
> Any media may be used in SS14 progress reports, with clear credit
given.
> 
> If you're unsure whether your PR will require media, ask a maintainer.
> 
> Check the box below to confirm that you have in fact seen this (put an
X in the brackets, like [X]):
> -->
> 
>
https://github.com/space-wizards/space-station-14/assets/27281377/d758d88f-6b55-4b18-937c-e56c967cfbe0
> 
> - [x] I have added screenshots/videos to this PR showcasing its
changes ingame, **or** this PR does not require an ingame showcase
> 
> ## Breaking changes
> <!--
> List any breaking changes, including namespace, public
class/method/field changes, prototype renames; and provide instructions
for fixing them. This will be pasted in #codebase-changes.
> -->
> 
> **Changelog**
> <!--
> Make players aware of new features and changes that could affect how
they play the game by adding a Changelog entry. Please read the
Changelog guidelines located at:
https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog
> -->
> 
> <!--
> Make sure to take this Changelog template out of the comment block in
order for it to show up.
> 🆑
> - add: Added fun!
> - remove: Removed fun!
> - tweak: Changed fun!
> - fix: Fixed 
> -->
> 
> 🆑 Luminight
> - fix: Wooden fence gate sprites are no longer swapped.


</details>

Co-authored-by: SimpleStation14 <Unknown>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item. D3: Low Difficulty: Some codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
Development

No branches or pull requests

3 participants