Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPCs are so fucking stupid around railings #26330

Closed
lzk228 opened this issue Mar 22, 2024 · 4 comments · Fixed by #26351 or Simple-Station/Einstein-Engines#307
Closed

NPCs are so fucking stupid around railings #26330

lzk228 opened this issue Mar 22, 2024 · 4 comments · Fixed by #26351 or Simple-Station/Einstein-Engines#307

Comments

@lzk228
Copy link
Contributor

lzk228 commented Mar 22, 2024

they just stop moving

Screenshot_20240319_233322
@Hmeister-real
Copy link
Contributor

NPC's in general right now are fucking stupid, they get stuck in walking loops and just start walking and stop randomly in the centre of rooms for prolonged periods of time, i dunno what even changed it, they were fine before. They need a full behavior rework imo

@metalgearsloth
Copy link
Contributor

NPC's in general right now are fucking stupid, they get stuck in walking loops and just start walking and stop randomly in the centre of rooms for prolonged periods of time, i dunno what even changed it, they were fine before. They need a full behavior rework imo

Has nothing to do with this.

@Hmeister-real
Copy link
Contributor

Has nothing to do with this.

It does, i'm suggesting they need a rework and saying that they have become more stupid in general, not just around railings

@metalgearsloth
Copy link
Contributor

Has nothing to do with this.

It does, i'm suggesting they need a rework and saying that they have become more stupid in general, not just around railings

This is coming from me, a 1-line change to pathfindersystem does not warrant throwing out 2k lines of code.

@metalgearsloth metalgearsloth mentioned this issue Mar 23, 2024
Merged
@SimpleStation14 SimpleStation14 mentioned this issue Apr 22, 2024
Merged
VMSolidus added a commit to Simple-Station/Einstein-Engines that referenced this issue Jul 9, 2024
@SimpleStation14 @VMSolidus
Mirror: NPC Steering Tweaks (#307)
399bd96 
## Mirror of PR #26351: [NPC steering
tweaks](space-wizards/space-station-14#26351)
from <img src="https://avatars.githubusercontent.com/u/10567778?v=4"
alt="space-wizards" width="22"/>
[space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14)

###### `64b648ff3c5183393b28285909e6b62c2b66663e`

PR opened by <img
src="https://avatars.githubusercontent.com/u/31366439?v=4"
width="16"/><a href="https://github.com/metalgearsloth">
metalgearsloth</a> at 2024-03-23 01:33:33 UTC

---

PR changed 2 files with 20 additions and 18 deletions.

The PR had the following labels:


---

<details open="true"><summary><h1>Original Body</h1></summary>

> - Fix the free node check considering the whole tile and not the poly,
this fixes 26330.
> - Clear maps on direction resets.
> - More robust arrival checks for pathfinding nodes.
> 
> Resolves
space-wizards/space-station-14#26330
> 
> 🆑
> - fix: Fix NPCs getting stuck on railings.
> 


</details>

Signed-off-by: VMSolidus <[email protected]>
Co-authored-by: SimpleStation14 <Unknown>
Co-authored-by: VMSolidus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@metalgearsloth @Hmeister-real @lzk228