Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fax machine print from text file doesn't appear to be logged #25694

Closed
Chief-Engineer opened this issue Feb 29, 2024 · 2 comments · Fixed by #25911
Closed

Fax machine print from text file doesn't appear to be logged #25694

Chief-Engineer opened this issue Feb 29, 2024 · 2 comments · Fixed by #25911
Labels
D3: Low Difficulty: Some codebase knowledge required. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P1: High Priority: Higher priority than other items, but isn't an emergency.

Comments

@Chief-Engineer
Copy link
Contributor

Feature introduced in #23262

Log should include:

  • Person printing the file, labeled as "actor"
  • Entity being printed, (the paper) labeled as "subject"
  • Device used to print the paper, labeled as "tool"
  • Text on the paper at the end of the log message with no trailing text/punctuation

Log type should be chat and severity should be low.

See how paper system logs writing, but imagine the paper is labeled "subject" instead of "entity":

space-station-14/Content.Server/Paper/PaperSystem.cs

Lines 161 to 162 in ba4188a

_adminLogger.Add(LogType.Chat, LogImpact.Low,
$"{ToPrettyString(args.Session.AttachedEntity.Value):player} has written on {ToPrettyString(uid):entity} the following text: {args.Text}");

@Chief-Engineer Chief-Engineer added the P1: High Priority: Higher priority than other items, but isn't an emergency. label Feb 29, 2024
@Chief-Engineer Chief-Engineer moved this to 🔖 Defined in NextGen WizDen Adminning Feb 29, 2024
@metalgearsloth metalgearsloth added D3: Low Difficulty: Some codebase knowledge required. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. labels Feb 29, 2024
@metalgearsloth
Copy link
Contributor

This also needs to include copying which has never been logged.

@noverd
Copy link
Contributor

noverd commented Feb 29, 2024

Ok, i do.

This was referenced Mar 7, 2024
Closed
Merged
@Chief-Engineer Chief-Engineer linked a pull request Mar 12, 2024 that will close this issue
More fax logging #25911
Merged
1 task
@github-project-automation github-project-automation bot moved this from 🔖 Defined to ✅ Done in NextGen WizDen Adminning Mar 13, 2024
@SimpleStation14 SimpleStation14 mentioned this issue Apr 21, 2024
Merged
VMSolidus pushed a commit to Simple-Station/Einstein-Engines that referenced this issue May 5, 2024
@SimpleStation14 @Deatherd
Mirror: More fax logging (#174)
74abdb9 
## Mirror of PR #25911: [More fax
logging](space-wizards/space-station-14#25911)
from <img src="https://avatars.githubusercontent.com/u/10567778?v=4"
alt="space-wizards" width="22"/>
[space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14)

###### `c27c7086c0acc41b3f58710811bd9358de94fc8c`

PR opened by <img
src="https://avatars.githubusercontent.com/u/69344159?v=4"
width="16"/><a href="https://github.com/Deatherd"> Deatherd</a> at
2024-03-07 15:31:19 UTC
PR merged by <img
src="https://avatars.githubusercontent.com/u/19864447?v=4"
width="16"/><a href="https://github.com/web-flow"> web-flow</a> at
2024-03-13 09:03:12 UTC

---

PR changed 1 files with 13 additions and 2 deletions.

The PR had the following labels:
- Status: Needs Review


---

<details open="true"><summary><h1>Original Body</h1></summary>

> <!-- Please read these guidelines before opening your PR:
https://docs.spacestation14.io/en/getting-started/pr-guideline -->
> <!-- The text between the arrows are comments - they will not be
visible on your PR. -->
> 
> ## About the PR
> Added logging for copying and printing from a file using fax.
> 
> ## Why / Balance
> My solution for issue
[#25694](space-wizards/space-station-14#25694),
that takes into account the logic of fax operation.
> 
> ## Technical details
> Now an admin log is added when adding a fax task to copy or print from
a file.
> 
> ## Media
> <!-- 
> PRs which make ingame changes (adding clothing, items, new features,
etc) are required to have media attached that showcase the changes.
> Small fixes/refactors are exempt.
> Any media may be used in SS14 progress reports, with clear credit
given.
> 
> If you're unsure whether your PR will require media, ask a maintainer.
> 
> Check the box below to confirm that you have in fact seen this (put an
X in the brackets, like [X]):
> -->
> 
> - [X] I have added screenshots/videos to this PR showcasing its
changes ingame, **or** this PR does not require an ingame showcase
> 
> ## Breaking changes
> <!--
> List any breaking changes, including namespace, public
class/method/field changes, prototype renames; and provide instructions
for fixing them. This will be pasted in #codebase-changes.
> -->
> 
> **Changelog**
> <!--
> Make players aware of new features and changes that could affect how
they play the game by adding a Changelog entry. Please read the
Changelog guidelines located at:
https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog
> -->
> 
> <!--
> Make sure to take this Changelog template out of the comment block in
order for it to show up.
> 🆑
> - add: Added fun!
> - remove: Removed fun!
> - tweak: Changed fun!
> - fix: Fixed fun!
> -->
> 


</details>

Co-authored-by: Deatherd <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
D3: Low Difficulty: Some codebase knowledge required. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P1: High Priority: Higher priority than other items, but isn't an emergency.
Projects
NextGen WizDen Adminning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

More fax logging Deatherd/space-cosmonauts
3 participants
@metalgearsloth @noverd @Chief-Engineer