Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Armor isn't predicted #15273

Closed
mirrorcult opened this issue Apr 10, 2023 · 0 comments · Fixed by #20560
Closed

Armor isn't predicted #15273

mirrorcult opened this issue Apr 10, 2023 · 0 comments · Fixed by #20560
Labels
D3: Low Difficulty: Some codebase knowledge required. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result.

Comments

@mirrorcult
Copy link
Contributor

Description

should be easy enough to fix by just putting the relay code in shared

Reproduction

  1. check out Let people melee attack themselves #15272
  2. wear captains armor
  3. attack self repeatedly with spear or something
  4. mispredict because client thinks you should be taking more damage than you actually are

Screenshots

Additional context
@ElectroJr ElectroJr added D3: Low Difficulty: Some codebase knowledge required. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. labels Apr 11, 2023
zhoan1 added a commit to zhoan1/space-station-14 that referenced this issue Apr 18, 2023
@zhoan1
Resolving issue: "Armor isn't predicted space-wizards#15273"
c708365 
Armor mitigation should be properly when attacking self. Changes made via moving ArmorComponent.cs to a new folder in Shared and adding a new file called ArmorDamageSystem in that same folder.
zhoan1 added a commit to zhoan1/space-station-14 that referenced this issue Apr 18, 2023
@zhoan1
Merge pull request #1 from zhoan1/SelfArmorDamage
7a991b5 
Resolving issue: "Armor isn't predicted space-wizards#15273"
@zhoan1 zhoan1 mentioned this issue Apr 18, 2023
Merged
1 task
zhoan1 added a commit to zhoan1/space-station-14 that referenced this issue Apr 18, 2023
@zhoan1
Resolving issue: "Armor isn't predicted space-wizards#15273"
7e4069d 
Armor mitigation should be properly when attacking self. Changes made via moving ArmorComponent.cs to a new folder in Shared and adding a new file called ArmorDamageSystem in that same folder.
@zhoan1 zhoan1 mentioned this issue Apr 18, 2023
Closed
1 task
@EmoGarbage404 EmoGarbage404 mentioned this issue Sep 28, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
D3: Low Difficulty: Some codebase knowledge required. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Predicted armor EmoGarbage404/space-station-14
2 participants
@mirrorcult @ElectroJr