offgrid friction in island solver #5263
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Comment on lines
+755
to
+760
| float? linearDampingOverride = null; | ||
| var entity = new Entity<PhysicsComponent, TransformComponent>(body.Owner, body, xform); | ||
| OnGetLinearDampingOverride?.Invoke(ref entity, ref linearDampingOverride); | ||
| var linearDamping = linearDampingOverride ?? body.LinearDamping; | ||
|
|
||
| linearVelocity *= Math.Clamp(1.0f - data.FrameTime * linearDamping, 0.0f, 1.0f); |
There was a problem hiding this comment.
Couple more questions:
- Do you have the content code that will be using this PRd? As it looks like the linked content PR doesn't use it.
- Does just subscribing to entity parent changes and using the body's lineardamping work? As this will also severely impact servers like RMC14 with the overhead.
There was a problem hiding this comment.
- the linked content PR uses the
OnGetLinearDampingOverride. - i don't follow what you mean with the suggestion of using the parent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part 2 of space-wizards/space-station-14#29383
adds support for friction to be modified when off grid.
this is primarily to help facilitate different gameplay levels when working off-grid vs while working on a weightless grid.
pretty shrimple pr.